Last modified: 2009-02-24 18:02:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19648, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 17648 - Prevent floats from intruding into edit area in previews if no toolbar present
Prevent floats from intruding into edit area in previews if no toolbar present
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Church of emacs
: patch, patch-need-review
Depends on:
Blocks: css
  Show dependency tree / graph
 
Reported: 2009-02-24 13:45 UTC by Church of emacs
Modified: 2009-02-24 18:02 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add br clear if the toolbar is not active. (479 bytes, patch)
2009-02-24 13:45 UTC, Church of emacs 		Details
uses CSS instead of inserting HTML code (406 bytes, patch)
2009-02-24 16:26 UTC, Church of emacs 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Church of emacs 2009-02-24 13:45:28 UTC 
Created attachment 5859 [details]
Add br clear if the toolbar is not active.

In shared.css, #toolbar is given the style clear:both; to avoid floats intruding from the text area. (for example: an image that floats on the side, see this for an example how it should NOT be: [[:w:de:Image:Brclearmissing.png]]).
If the user turns off the toolbar in his preferences, or if he doesn't activate Javascript, this fails (see linked image above). The attached patch should fix this, as it gives out a <br clear="both"/> if the toolbar is not active.
Comment 1 Church of emacs 2009-02-24 13:47:18 UTC 
Fixed link: [[:de:Image:Brclearmissing.png]]
(I think bugzilla needs a preview option as well :))
Comment 2 Church of emacs 2009-02-24 13:51:38 UTC 
Comment on attachment 5859 [details]
Add br clear if the toolbar is not active.

typo
Comment 3 Danny B. 2009-02-24 16:01:21 UTC 
Please, do not clutter the code with unnecessary markup. Add "clear: both;" as a part of CSS style to the form instead. It will serve the same and the code will remain the same.
Comment 4 Church of emacs 2009-02-24 16:26:39 UTC 
Created attachment 5865 [details]
uses CSS instead of inserting HTML code

I'm Sorry. This should fix it.
Comment 5 Danny B. 2009-02-24 18:02:08 UTC 
Fixed in r47754.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links