Last modified: 2009-03-28 16:41:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19617, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17617 - HTML tweaks / Clean up ImagePage.php
HTML tweaks / Clean up ImagePage.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Fil...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-22 19:59 UTC by Umherirrender
Modified: 2009-03-28 16:41 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Wrap "morelinkstoimage" within the div "mw-imagepage-section-linkstoimage" (diff to r47394) (32.27 KB, patch)
2009-02-22 19:59 UTC, Umherirrender
Details
a diff instead a new file of ImagePage.php (2.79 KB, patch)
2009-02-22 22:29 UTC, Umherirrender
Details
new Patch with more tweaks (7.70 KB, patch)
2009-02-23 22:10 UTC, Umherirrender
Details
new patch with using quots for atts (7.58 KB, patch)
2009-03-27 18:37 UTC, Umherirrender
Details
new patch for HTML tweaks on ImagePage.php (6.40 KB, patch)
2009-03-28 13:51 UTC, Umherirrender
Details

Description Umherirrender 2009-02-22 19:59:44 UTC
Created attachment 5848 [details]
Wrap "morelinkstoimage" within the div "mw-imagepage-section-linkstoimage" (diff to r47394)

Please clean up the imagePage.php to have proper HTML and no more FIXME/TODO in source.

I have make a few little change. My matter is to wrap "morelinkstoimage" within the div "mw-imagepage-section-linkstoimage", because it belongs to the other things in that div.

I cannot help by the TODO and FIXME.

I hope "user interface" is the right component.
Thank you.
Comment 1 Umherirrender 2009-02-22 22:29:22 UTC
Created attachment 5849 [details]
a diff instead a new file of ImagePage.php

I have create a diff, instead of a new file with more little change then the first attachment.
Comment 2 Umherirrender 2009-02-23 22:10:45 UTC
Created attachment 5854 [details]
new Patch with more tweaks

My last try to make the HTML-Source more readable and add two divs. One for the metadata-section and one for the filehistory-section. Wrap "morelinkstoimage" into the existing div. Add ids "reupload-link" and "edit-external".

Feel free to change anything or make more. Thanks.
Comment 3 Chad H. 2009-03-19 18:32:03 UTC
Please resubmit without changing <tag attr=""> to <tag attr=''>. We generally use the former and changing these is useless.

Also, patch does not apply, I get a mis-smatched chunks error.
Comment 4 Umherirrender 2009-03-27 18:37:20 UTC
Created attachment 5967 [details]
new patch with using quots for atts

I hope the new patch is better and can used in the way you want used it.

I had not work with patch before.
Comment 5 Patrick Westerhoff 2009-03-27 18:45:37 UTC
Sorry, but I don't like your patch. You don't need to use always the same quote-style. You can mix them and by that save a lot escapes, which makes the code a lot more readable.

Example (and that is completely fine):
$wgOut->addHTML( '<div id="shared-image-desc">' . $this->mExtraDescription . "</div>\n" );

Comment 6 Chad H. 2009-03-27 19:26:18 UTC
Agree with Patrick. Also, I'm still getting the mis-matched chunks error. Are you diff'ing against trunk?
Comment 7 Umherirrender 2009-03-28 13:51:57 UTC
Created attachment 5973 [details]
new patch for HTML tweaks on ImagePage.php

I have download the php-Script from http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/ImagePage.php?revision=48951&view=markup&pathrev=48957

Open with [[WinMerge]], make the change and create a unified patch and attached them

I do not know it was a good idee but you can find the source on my sandbox under http://de.wikipedia.org/w/index.php?action=edit&oldid=58412452&uselang=en (diff: http://de.wikipedia.org/w/index.php?diff=58412452&oldid=58412402&uselang=en)

I hope you can work with that.
Comment 8 Chad H. 2009-03-28 16:41:16 UTC
Awesome. Done in r48967.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links