Last modified: 2014-11-18 18:07:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19602, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17602 - Monobook action tabs are off one pixel in certain browsers
Monobook action tabs are off one pixel in certain browsers
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Low trivial with 3 votes (vote)
: ---
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-21 20:03 UTC by Tisza Gergő
Modified: 2014-11-18 18:07 UTC (History)
3 users (show)

See Also:
Web browser: Opera
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2009-02-21 20:03:16 UTC
In the Monobook skin, under IE and Opera, the borders of the tabs (edit, move etc. - with the exception of the currently active tab) on top of the article don't quite attach to the block below - there is a small gap (one pixel with usual em sizes). Hard to notice, but it is rather ugly once you do.

Under Opera, #p-cactions { margin-top: 1px; } seems to fix it, and under IE 6, #p-cactions a { padding-bottom: 1px; } works.

(Tested under IE6, Opera 9.63, Opera 10 beta on Win XP. The problem also appears on IE7, but the fix was not tested there.)
Comment 1 Bartosz Dziewoński 2013-04-20 19:24:35 UTC
Confirming, still happens on Opera 12.15 today.

This is caused by insufficient bottom padding on the tabs (0.1em on normal ones, and for some reason 0.2em on active ones, which is apparently enough) - apparently Opera has slightly different defaults or something.

I'll submit a patch to raise it to something ridiculous like 1em, just in case. This shouldn't cause any issues, as the z-indices are set reasonably on all involved elements.
Comment 2 Gerrit Notification Bot 2013-04-20 19:31:34 UTC
Related URL: https://gerrit.wikimedia.org/r/60123 (Gerrit Change I07223ba46913f721907f9aa88f79bc94402b6cf6)
Comment 3 Gerrit Notification Bot 2013-05-19 19:44:46 UTC
https://gerrit.wikimedia.org/r/60123 (Gerrit Change I07223ba46913f721907f9aa88f79bc94402b6cf6) | change APPROVED and MERGED [by TheDJ]
Comment 4 Bartosz Dziewoński 2013-05-19 19:47:42 UTC
Merged, should be fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links