Last modified: 2014-09-24 00:02:49 UTC
Created attachment 5836 [details] countRevisionsBetween using timestamps For example http://en.wikipedia.org/w/index.php?title=Apple&diff=269860524&oldid=234474 states: (4580 intermediate revisions not shown) (4582) instead of: (4598 intermediate revisions not shown) (4600) Because there is 18 revisions is Apple history which have rev_ids < 234474 and timestamp > 2001-10-24T01:47:59Z (see http://en.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Apple&rvprop=ids|user|timestamp&rvlimit=100&rvdir=newer&format=jsonfm) Is this a known/real issues: is the intended behaviour to sort by revids when counting revisions between diffed version ? If not, feel free to review the attached patch, which switch countRevisionsBetween behaviour to count revisions between timestamps instead of revids. Thanks in advance.
Johan Euphrosine: thank you for the bug report and the patch. Adding the "need-review" keyword to indicate that you're waiting for a response to the patch. My apologies that it's been so long.
Comment on attachment 5836 [details] countRevisionsBetween using timestamps This patch no longer applies to trunk per Rusty Burchfield's automated testing https://docs.google.com/spreadsheet/ccc?key=0Ah_71HHl7qa7dGtvSms3TGpHQU9NU2Y1VmNzUEUteWc .
Johan Euphrosine, I'm sorry that it took so long for us to review your patch. If the issue is still one you're interested in fixing, please join us in IRC https://www.mediawiki.org/wiki/MediaWiki_on_IRC and talk with other developers before renewing and possibly revising your approach. Thanks for your interest in improving MediaWiki!
