Last modified: 2013-06-16 20:50:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19583, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17583 - 1movedto2 and 1movedto2_redir used inconsistently
1movedto2 and 1movedto2_redir used inconsistently
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-20 08:33 UTC by Niklas Laxström
Modified: 2013-06-16 20:50 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2009-02-20 08:33:39 UTC
Definition of the messages are of form: "moved [[$1]] to [[$2]]"

However some code in ChangeList.php is passing html links to it:

# "[[x]] moved to [[y]]"
$msg = ( $rc->mAttribs['rc_type'] == RC_MOVE ) ? '1movedto2' : '1movedto2_redir';
$s .= wfMsg( $msg, $this->skin->makeKnownLinkObj( $rc->getTitle(), '', 'redirect=no' ),
  $this->skin->makeKnownLinkObj( $rc->getMovedToTitle(), '' ) );
--
// Page moves
if( $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
  $msg = ( $rc_type == RC_MOVE ) ? "1movedto2" : "1movedto2_redir";
  $clink = wfMsg( $msg, $this->skin->makeKnownLinkObj( $rc->getTitle(), '', 'redirect=no' ),
     $this->skin->makeKnownLinkObj( $rc->getMovedToTitle(), '' ) );

The code should either be fixed, or if it is obsolete (from the time before new logging system), it should perhaps be removed.
Comment 1 Niklas Laxström 2009-07-28 14:49:43 UTC
ChangesList needs cleanup.
Comment 2 Niklas Laxström 2013-06-16 20:50:42 UTC
Such code doesn't seem to exist anymore.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links