Last modified: 2013-06-18 15:39:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19558, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17558 - WMF servers missing part of cl_sortkey index, live hack breaks list=categorymembers&cmsort=sortkey
WMF servers missing part of cl_sortkey index, live hack breaks list=categorym...
Status: RESOLVED DUPLICATE of bug 27965
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 16012
  Show dependency treegraph
 
Reported: 2009-02-18 19:34 UTC by Roan Kattouw
Modified: 2013-06-18 15:39 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2009-02-18 19:34:45 UTC
The WMF servers have KEY `cl_timestamp` (`cl_to`,`cl_timestamp`) whereas tables.sql has CREATE INDEX /*i*/cl_sortkey ON /*_*/categorylinks (cl_to,cl_sortkey,cl_from) . The cl_from field in the index is needed to make list=categorymembers&cmsort=sortkey non-lethal to the database servers, but because it's not there on the WMF servers, WMF uses a live hack that breaks paging for cmsort=sortkey completely.

The index should be updated on all WMF servers and the live hack removed.
Comment 1 Roan Kattouw 2009-02-18 22:38:00 UTC
Changing product and component, this is a WMF issue
Comment 2 Tim Starling 2009-06-08 07:06:00 UTC
Not sure what the cl_timestamp key has to do with anything. Wikimedia appears to be missing patch-categorylinksindex.sql, from bug 10280. That is, it has an index called cl_sortkey already, but it is (cl_to,cl_sortkey) instead of (cl_to,cl_sortkey,cl_from). 
Comment 3 Roan Kattouw 2009-06-08 07:07:11 UTC
(In reply to comment #2)
> Not sure what the cl_timestamp key has to do with anything. Wikimedia appears
> to be missing patch-categorylinksindex.sql, from bug 10280. That is, it has an
> index called cl_sortkey already, but it is (cl_to,cl_sortkey) instead of
> (cl_to,cl_sortkey,cl_from). 
> 

Yeah, that's probably what I meant; the cl_timestamp thing must've been a mistake.
Comment 4 Bugmeister Bot 2011-08-19 19:12:59 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 5 Marcin Cieślak 2012-03-16 01:56:44 UTC
Most probably fixed in r83814 and following commits.

*** This bug has been marked as a duplicate of bug 27965 ***
Comment 6 Bawolff (Brian Wolff) 2012-03-16 02:06:31 UTC
(In reply to comment #5)
> Most probably fixed in r83814 and following commits.
> 
> *** This bug has been marked as a duplicate of bug 27965 ***

You sure? the issues don't sound that related to me.
Comment 7 Marcin Cieślak 2012-03-16 02:27:09 UTC
We should have now this:

CREATE INDEX /*i*/cl_sortkey ON /*_*/categorylinks (cl_to,cl_type,cl_sortkey,cl_from);

in production, otherwise it would have problems with not using the index.

Paging a sorted categorylinks was pretty broken here anyway.
Comment 8 Bawolff (Brian Wolff) 2012-03-16 02:28:21 UTC
(In reply to comment #7)
> We should have now this:
> 
> CREATE INDEX /*i*/cl_sortkey ON /*_*/categorylinks
> (cl_to,cl_type,cl_sortkey,cl_from);
> 
> in production, otherwise it would have problems with not using the index.
> 
> Paging a sorted categorylinks was pretty broken here anyway.

Good point.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links