Last modified: 2010-05-15 16:02:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19506, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 17506 - Exceptions inside Exception ignore $wgShowExceptionDetails
Exceptions inside Exception ignore $wgShowExceptionDetails
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.13.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://wikicafe.metacafe.com
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-02-15 15:06 UTC by David Tabachnikov
Modified: 2010-05-15 16:02 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Display the backtrace only if the wgShowExceptionDetails flag is enabled. (980 bytes, patch)
2009-02-15 15:06 UTC, David Tabachnikov 		Details
Add an attachment (proposed patch, testcase, etc.)

Description David Tabachnikov 2009-02-15 15:06:46 UTC 
Created attachment 5817 [details]
Display the backtrace only if the wgShowExceptionDetails flag is enabled.

When there's an exception inside an exception handler, (such as when the $name parameter to SkinTemplate::makeTalkUrlDetails() is passed as "User:"), the backtrace is printed to the screen in any case, wherever $wgShowExceptionDetails is enabled or not.

On production sites - this a security vulnerability, because it shows all the paths to the files on the servers.

Attached a patch that makes it print the backtrace only in the case that the wgShowExceptionDetails value is set.
Comment 1 David Tabachnikov 2009-02-15 15:07:45 UTC 
The bug was found and fixed by David Tabachnikov and Romi Romano from Metacafe.
Comment 2 Chad H. 2009-02-16 04:34:30 UTC 
Done in r47305
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links