Wikimedia Bugzilla is closed!

Empty bug report. Suggest WONTFIX based on summary alone. Needs further info from reporter as to why this should be done (I don't see any reason not to confirm that they were saved).

After saving preferences, a message is displayed that says "Your preferences
have been saved.". But if I keep doing changes to my preferences, and I leave
my computer, then when I come back in front of my screen, I don't remember
whether or not my changes have been saved. Some JavaScript code could
automatically hide this message when changing preferences.

(Sorry, I didn't mean to type Enter so early...)
(And sorry for my bad English)

Ah ok! That makes a lot more sense. I originally understood this was "Using JS
to hide preferences" always. Didn't see a reason there :)

:)

Giving this to Andrew, low priority.

I suggest we not make messages mysteriously disappear after a timeout.  That's confusing.  People might not be done reading them, or they might have taken the action, switched to another tab/window, and only come back half an hour later.  No message should disappear after a time period has elapsed, unless maybe it's intrinsically time-sensitive and no longer makes sense.

I'd hide it whenever a preference is changed.

That would be sensible.

If we're going to show and hide this after a timer if prefer it was a floating fixed element rather than an in-line one, A. So the user sees it, and B. So it isn't making the content of the page refactor when it appears and disappears. If reccomend 4 seconds for the time on screen. 

To address the issue of "knowing if it saved" I'd recommend disabling the save button if no changes have been made since last save. I don't think this is absolute needed but it's another reminder that there is nothing you need to do.

Hi I am new here and wanted to work on this bug.
I implemented it as this-Whenever a user changes the preferences tab or reloads or clicks on any section of the preferences tabs, the message is hidden. Is it a good implementation?
I liked Jared's idea as well. Can anyone suggest how I should implement it?

(In reply to comment #10)
> Hi I am new here and wanted to work on this bug.
> I implemented it as this-Whenever a user changes the preferences tab or
> reloads
Great. I will assign the same to you.

Created attachment 14325 [details]
Patch to remove success box on changing any preference or switching tab

I was unable to submit the patch to gerrit directly because of ISP issues.
As suggested by sumanah on IRC, I tried to submit it using the online gerrit uploader but it gave me an error as well.
So I posted the patch here directly.
Can someone please review it and tell if I should modify it.

Submitted a patch successfully here
https://gerrit.wikimedia.org/r/#/c/107837/

Change 107837 had a related patch set uploaded by 01tonythomas:
Patch to remove success box on changing any preference or switching tab

https://gerrit.wikimedia.org/r/107837

(In reply to comment #12)
> Created attachment 14325 [details]
> Patch to remove success box on changing any preference or switching tab
You should go through 
www.mediawiki.org/wiki/Gerrit/Tutorial
next time to submit a patch using git-review.

Thank you Tony. I was unable to submit a patch because my proxy doesn't allow SSH to Gerrit port. I will try and submit it through git-review next time by some other internet connection.

Thank you Tony. I was unable to submit a patch because my proxy doesn't allow SSH to Gerrit port. I will try and submit it through git-review next time by some other internet connection.