Last modified: 2014-03-06 21:53:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19475, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17475 - Index (for search) sighted revisions only on de-wp
Index (for search) sighted revisions only on de-wp
Status: ASSIGNED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: Normal enhancement with 13 votes (vote)
: ---
Assigned To: Chad H.
http://de.wikipedia.org/wiki/Spezial:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-13 08:00 UTC by Gnu1742
Modified: 2014-03-06 21:53 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gnu1742 2009-02-13 08:00:21 UTC
Please evaluate the possibility that the search engine indexes sighted revisions only. This is to prevent vandalism to be displayed at a prominent place.

Background: After the elections in Israel a few days ago the articles about the candidates like Benjamin Netanjahu are both interesting for readers and target to vandals.
This article was vandalised on the 12th february at 04:29 CET in a horrible way (think of Hitler and the Shoah and you'll guess what i mean). The vandalism was undone about 15 minutes later and the revision was deleted in the meantime. Unfortunately the daily search-indexing of de-wp took place during that quarter of an hour, so the vandalism showed up every time someone searched for Netanjahu. When i was told about this i asked at #wikimedia-tech to manually re-index de-wp.

Every article on de-wp has a sighted revision by now, so this solution would prevent offenses like the one described above.
Comment 1 Aaron Schulz 2009-02-13 16:41:30 UTC
Isn't this already done?
Comment 2 Aaron Schulz 2009-02-13 16:44:37 UTC
(In reply to comment #1)
> Isn't this already done?
> 

Nevermind, missed the term "search engine" :)
Comment 3 Robert Stojnic 2009-02-13 16:45:59 UTC
Index is updated using articles from OAI repository and/or xml dumps. AFAIK, OAI doesn't know distinction between sighted or not. Not sure if dumpBackup has a switch to get sighted versions only?
Comment 4 Gnu1742 2009-02-13 16:48:26 UTC
Well, that is the reason why i started with 'please evaluate the possibility...'... Anyway: What is OAI?
Comment 5 Aaron Schulz 2009-02-13 16:50:35 UTC
Edits call SearchUpdate(), so normally a revert would update the search index...does the lucene engine head those calls?
Comment 6 Robert Stojnic 2009-02-13 16:58:37 UTC
No, lucene backend periodically fetches new changes from the OAI repository (which contains all the changes made to the wiki). AFAIK, SearchUpdate is only used in built-in MW search. 
Comment 7 Gnu1742 2010-01-26 08:10:59 UTC
Has anything been done about this issue? It's the bugs 1st birthday in a few days ;-)
Comment 8 Andre Klapper 2013-03-26 11:19:45 UTC
[Merging "MediaWiki extensions/Lucene Search" into "Wikimedia/lucene-search2", see bug 46542. You can filter bugmail for: search-component-merge-20130326 ]
Comment 9 Nemo 2013-08-29 16:53:36 UTC
This looks possible, though definitely low priority, with the new CirrusSearch: as it uses some queue system, I suppose the index update could be delayed until the revision is approved. (May need to be moved to FlaggedRevs component if the search system already allows such modifications.)
Comment 10 Nik Everett 2013-08-29 19:59:23 UTC
This will be significantly mitigated with CirrusSearch because it updates articles right after they are changed.  I'm not sure how it interacts with FlaggedRevs at the moment but I'll be sure to have a look at some point in the future.
Comment 11 Gerrit Notification Bot 2013-12-30 22:11:16 UTC
Change 104675 had a related patch set uploaded by Chad:
Support FlaggedRevs

https://gerrit.wikimedia.org/r/104675
Comment 12 Gerrit Notification Bot 2014-01-17 22:33:09 UTC
Change 104675 abandoned by Chad:
Support FlaggedRevs

Reason:
With the latest implementation in Iff0bf5d5 this isn't needed anymore. We'll add a hook to FlaggedRevs to support it.

https://gerrit.wikimedia.org/r/104675

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links