Last modified: 2010-05-15 16:03:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19472, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17472 - use print <<<EOF in maintenance/importTextFile.php instead of 11 echos
use print <<<EOF in maintenance/importTextFile.php instead of 11 echos
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.13.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-12 21:39 UTC by Dan Jacobson
Modified: 2010-05-15 16:03 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
maintenance/importTextFile.php print <<< patch (1.23 KB, patch)
2009-02-12 21:39 UTC, Dan Jacobson
Details

Description Dan Jacobson 2009-02-12 21:39:42 UTC
Created attachment 5809 [details]
maintenance/importTextFile.php print <<< patch

Here's a patch to use print <<<EOF in maintenance/importTextFile.php instead of 11 echos.

Consider doing the same in other scripts.

Also perhaps use echo basename(__FILE__) instead of hardwiring the file name into the usage message.

You can use \t's if you are worried the real tabs will get injured next edit or something.
Comment 1 Dan Jacobson 2009-02-12 22:05:30 UTC
By the way, not all the defaults are mentioned.

E.g., you say
--title <title>
	Title for the new page; default is to use the filename as a base

But at
--user <user>
	User to be associated with the edit
you don't cough up the default. Same for other options.
Comment 2 Siebrand Mazeland 2009-02-15 00:20:50 UTC
Applied in r47279.
Comment 3 Dan Jacobson 2009-02-15 00:30:58 UTC
OK, thanks. But in the --help message do mention the defaults for each item.
Comment 4 Siebrand Mazeland 2009-02-15 00:37:24 UTC
(In reply to comment #3)
> OK, thanks. But in the --help message do mention the defaults for each item.
Please provide a patch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links