Last modified: 2010-05-15 15:38:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1746 - Subject of email-notifications must be quoted-printable.
Subject of email-notifications must be quoted-printable.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.5.x
PC All
: Normal normal (vote)
: ---
Assigned To: T. Gries
: patch
Depends on:
Blocks: 1932 454
  Show dependency treegraph
 
Reported: 2005-03-24 10:17 UTC by Stas Fomin
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
small patch, to quote "Subject" of notification, not Pagetitle. (909 bytes, patch)
2005-03-24 10:19 UTC, Stas Fomin
Details
complete patch for this bug (4.29 KB, patch)
2005-03-26 00:06 UTC, T. Gries
Details
Patch to reenable ENotifs when watching user visits watched page with changes (4.41 KB, patch)
2005-03-26 00:53 UTC, T. Gries
Details
patch (some diff lines which were not relevant to this bug have been removed) (4.13 KB, patch)
2005-03-26 01:10 UTC, T. Gries
Details
UserMailer.php -- complete module (15.38 KB, text/plain)
2005-03-26 01:19 UTC, T. Gries
Details

Description Stas Fomin 2005-03-24 10:17:19 UTC
In email notifications now (1.4b6-1.5-CVS) "Subject" is not quoted-printable, only 
pagetitle is quoted:
See UserMailer.php, function composeCommonMailtext:  

	$subject = str_replace( '$PAGETITLE_QP', wfQuotedPrintable( str_replace
( '_', ' ', $pagetitle ) ), $subject);

But if we localize (translate) user-mailer messages, then Subject may be unreadable in 
some email clients (for example Lotus Notes).
So we propose not to quote pagetitle, 
+	$subject = str_replace('$PAGETITLE_QP', str_replace( '_', ' ', $pagetitle), 
$subject);

but quote "Subject" itself
 	$this->replyto	= $replyto;
-	$this->subject	= $subject;
+	$this->subject	= wfQuotedPrintable($subject);
 	$this->body	= $body;
Comment 1 Stas Fomin 2005-03-24 10:19:03 UTC
Created attachment 381 [details]
small patch, to quote "Subject" of notification, not Pagetitle.

This is patch for 1.4b6 version of UserMailer.php, to quote "Subject" of
notification, not Pagetitle.
Comment 2 T. Gries 2005-03-24 17:31:22 UTC
(In reply to comment #1)
> Created an attachment (id=381) [edit]
> small patch, to quote "Subject" of notification, not Pagetitle.
> 
> This is patch for 1.4b6 version of UserMailer.php, to quote "Subject" of
> notification, not Pagetitle.

This need to be checked carefully.
I will keep care of your observation and patch.

By the way, e-mail notification is only in CVS HEAD (1.5), isn't it ? I did not
back-port it from there to 1.4.x versions.

Tom
- for ENotif and EAuthent
ENoitf: http://bugzilla.wikipedia.org/show_bug.cgi?id=454 and
EAuthent: http://bugzilla.wikipedia.org/show_bug.cgi?id=866
Comment 3 T. Gries 2005-03-24 17:41:07 UTC
(In reply to comment #2)
> > This is patch for 1.4b6 version of UserMailer.php, to quote "Subject" of...
> This needs to be checked carefully.

I forgot to add: Lotus Notes - I have made extremely bad experiences with this
touchy piece of software. Sometimes it appears not to be fully compliant to RFC
internet standards, but I am not sure. However, I noticed a strange behaviour
with the From: field, too.

So please let us change $subject and $from very very carefully: please no quick
changes, before new patches have been checked to be without side-effects. I
fully admit, that a thorough analysis of my whole string handling is still
needed, but any mail client must be checked.

Tom
- for ENotif and EAuthent
ENoitf: http://bugzilla.wikipedia.org/show_bug.cgi?id=454 and
EAuthent: http://bugzilla.wikipedia.org/show_bug.cgi?id=866
Comment 4 T. Gries 2005-03-25 18:13:47 UTC
This patch is for ENotif; ENotif is only in CVS HEAD (= 1.5).
(I still did not check it fully)
Comment 5 T. Gries 2005-03-26 00:06:22 UTC
Created attachment 386 [details]
complete patch for this bug

Patch. 
Please take note, that I slightly changed two strings in the messagetext
(template) Mediawiki:email_notification_subject in file Language.php :
$PAGETITLE_QP and $PAGEEDITOR_QP do not exist any longer. run /maintenance/php
rebuildMessages.php or change the two variabes by hand, please.
Comment 6 T. Gries 2005-03-26 00:53:00 UTC
Created attachment 387 [details]
Patch to reenable ENotifs when watching user visits watched page with changes

Patch
Comment 7 T. Gries 2005-03-26 01:10:43 UTC
Created attachment 388 [details]
patch (some diff lines which were not relevant to this bug have been removed)

patch
Comment 8 T. Gries 2005-03-26 01:19:30 UTC
Created attachment 389 [details]
UserMailer.php -- complete module
Comment 9 Brion Vibber 2005-03-26 02:20:21 UTC
Applied patch (had to shove some bits manually due to unknown problem)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links