Last modified: 2009-02-10 18:56:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19439, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17439 - Discard link on Special:Drafts does not work
Discard link on Special:Drafts does not work
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Drafts (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-10 18:43 UTC by Caleb Morse
Modified: 2009-02-10 18:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for bug described (864 bytes, patch)
2009-02-10 18:43 UTC, Caleb Morse
Details
Now uses getFullUrl() correctly (1.32 KB, patch)
2009-02-10 18:56 UTC, Caleb Morse
Details

Description Caleb Morse 2009-02-10 18:43:28 UTC
Created attachment 5801 [details]
Patch for bug described

The discard link on the drafts special page points to the following url: 

/index.php?title=Special:Drafts?discard=1&token=...

Instead of pointing to:

/index.php?title=Special:Drafts&discard=1&token=...

Patch attached.
Comment 1 Brion Vibber 2009-02-10 18:45:19 UTC
The extra URL params should be passed into getFullUrl() for appending rather than manually appended; this'll ensure consistent functioning whatever the $wgArticlePath format is.
Comment 2 Trevor Parscal 2009-02-10 18:50:00 UTC
Moved params into getFullUrl() as suggested. Thanks brion!
Comment 3 Caleb Morse 2009-02-10 18:56:32 UTC
Created attachment 5802 [details]
Now uses getFullUrl() correctly

I didn't realize that was possible. I updated the patch so that the params are passed into getFullUrl().

It looks like it will require some work to get the entire extension using getFullUrl().

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links