Last modified: 2009-02-11 10:55:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19417, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17417 - Query format ol should try to avoid Tidy bug
Query format ol should try to avoid Tidy bug
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: DaSch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-08 23:19 UTC by DaSch
Modified: 2009-02-11 10:55 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
this solves the problem (447 bytes, patch)
2009-02-10 17:59 UTC, DaSch
Details

Description DaSch 2009-02-08 23:19:39 UTC
ol lists are counted
2.
4.
6.
8.
...

SMW 1.5d
MW 1.14.0rc1
Comment 1 Markus Krötzsch 2009-02-09 10:58:56 UTC
<ol> Lists are numbered by the browser you use (the numbers do not appear in HTML). Please paste the problematic HTML snippet from the page and specify your browser and version. I cannot reproduce the issue on Firefox 3.0.5 using the SMW and MW version you describe.
Comment 2 DaSch 2009-02-09 11:45:03 UTC
this is definatly no Browser bug
the generated HTML looks like this

<ol>
<li style="list-style: none"></li>
<li><a href="/view/Berlin" title="Berlin">Berlin</a> (3.413.993)</li>

<li style="list-style: none"></li>
<li><a href="/view/Hamburg" title="Hamburg">Hamburg</a> (1.766.456)</li>
<li style="list-style: none"></li>
<li><a href="/view/M%C3%BCnchen" title="München">München</a> (1.351.445)</li>
<li style="list-style: none"></li>
<li><a href="/view/K%C3%B6ln" title="Köln">Köln</a> (991.395)</li>
<li style="list-style: none"></li>
<li><a href="/view/Frankfurt_am_Main" title="Frankfurt am Main">Frankfurt am Main</a> (667.468)</li>

<li style="list-style: none"></li>
<li><a href="/view/Stuttgart" title="Stuttgart">Stuttgart</a> (597.158)</li>
<li style="list-style: none"></li>
<li><a href="/view/Dortmund" title="Dortmund">Dortmund</a> (587.137)</li>
<li style="list-style: none"></li>
<li><a href="/view/Essen" title="Essen">Essen</a> (582.764)</li>
<li style="list-style: none"></li>
<li><a href="/view/D%C3%BCsseldorf" title="Düsseldorf">Düsseldorf</a> (578.326)</li>

<li style="list-style: none"></li>
<li><a href="/view/Bremen" title="Bremen">Bremen</a> (548.477)</li>
<li style="list-style: none"></li>
<li><a href="/view/Hannover" title="Hannover">Hannover</a> (518.010)</li>
<li style="list-style: none"></li>
<li><a href="/view/Leipzig" title="Leipzig">Leipzig</a> (510.512)</li>
<li style="list-style: none"></li>
<li><a href="/view/Dresden" title="Dresden">Dresden</a> (508.351)</li>

<li style="list-style: none"></li>
<li><a href="/view/N%C3%BCrnberg" title="Nürnberg">Nürnberg</a> (503.762)</li>
</ol>
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-02-09 11:47:54 UTC
This might be bug 9737.
Comment 4 DaSch 2009-02-09 11:57:41 UTC
well this seams to be a tidy-problem
deactivating tidy is making the bug disapear
Comment 5 Markus Krötzsch 2009-02-09 15:40:54 UTC
Good, then I am marking this as a duplicate of the according bug 9737.


*** This bug has been marked as a duplicate of bug 9737 ***
Comment 6 DaSch 2009-02-09 16:06:38 UTC
well, even if you're not willing to see, but there is a SMW related problem. Only lists that are generated through the #ask-parser show this effect, normal list greated by wiki syntax do not show thos effect

http://www.wecowi.de/view/Deutschland it's simple to recognize were the ask-parser works wrong and where normal wiki-syntax works right
Comment 7 DaSch 2009-02-10 12:45:33 UTC
if fact only the format=ul and format=ol have this problem

when generating a list with a template that contains
* {{{1|}}}
or
# {{{1|}}}
everything is correct, so it's a bug in the ol/ul-format
Comment 8 Markus Krötzsch 2009-02-10 16:50:51 UTC
Your observations are correct, but I do not come to the same conclusion: just because a bug in Tidy is triggered by some SMW output, it is still a bug in Tidy, not in SMW. I have checked SMW's ol output and it validates as XHTML 1.0 Strict, so I do not see any bug with it.

In general, it is not our main priority to find workarounds for bugs in other tools (I would like to do even this, but I am using all of my resources on SMW). However, we will be happy to apply modifications to the code if they help to avoid the problem you mention -- if you can track down the issue and suggest some concrete change in SMW (the code is in SMW_QP_List.php), then I will certainly consider applying your changes to SVN. As far as I can see, SMW-ol and MW-# differ only in some whitespace (which should really not be relevant in HTML, but apparently it confuses Tidy).

Since you seem to be unhappy about closing this bug as a duplicate of bug 9737, I now move it to the "LATER" queue (bugs that I will fix right after I have fixed the bugs that are in the "open" queue).
Comment 9 DaSch 2009-02-10 17:59:01 UTC
Created attachment 5798 [details]
this solves the problem

it wasn't that difficult 5 minutes work
Comment 10 Markus Krötzsch 2009-02-11 09:56:35 UTC
(In reply to comment #9)
> Created an attachment (id=5798) [details]
> this solves the problem
> 
> it wasn't that difficult 5 minutes work
> 

Thanks, that's the right attitude! :-)

I have committed your change to SVN now (sorry, it's not in SMW 1.4.2 yet, I saw the mail too late).
Comment 11 Markus Krötzsch 2009-02-11 10:55:04 UTC
In fact, this change was so tiny that I did update the 1.4.2 release files to include this fix now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links