Last modified: 2010-05-15 16:03:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19414, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17414 - staticredirect Magic word not found
staticredirect Magic word not found
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.13.x
All Linux
: Normal minor (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-08 21:21 UTC by miguelf
Modified: 2010-05-15 16:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description miguelf 2009-02-08 21:21:13 UTC
After upgrading mediawiki from rel-1.13.0rc1 to rel-1.13.4 the site started to crash.

After reviewing the trace below I ended working around the problem by commenting out the staticredirect keyword in the includes/MagicWord.php file as follows (but this is of course a work around until it gets fixed):

static public $mDoubleUnderscoreIDs = array($
  'notoc',
  'nogallery',
  'forcetoc',
  'toc',
  'noeditsection',
  'newsectionlink',
  'hiddencat',
  #'staticredirect',
);

--------- Output trace ----------
Magic word not found

Backtrace:

#0 /opt/mediawiki-1.13.4/includes/MagicWord.php(231): Language->getMagic(Object(MagicWord))
#1 /opt/mediawiki-1.13.4/includes/MagicWord.php(184): MagicWord->load('staticredirect')
#2 /opt/mediawiki-1.13.4/includes/MagicWord.php(529): MagicWord::get('staticredirect')
#3 /opt/mediawiki-1.13.4/includes/MagicWord.php(549): MagicWordArray->getBaseRegex()
#4 /opt/mediawiki-1.13.4/includes/MagicWord.php(652): MagicWordArray->getRegex()
#5 /opt/mediawiki-1.13.4/includes/parser/Parser.php(3369): MagicWordArray->matchAndRemove('This page has b...')
#6 /opt/mediawiki-1.13.4/includes/parser/Parser.php(978): Parser->doDoubleUnderscore('This page has b...')
#7 /opt/mediawiki-1.13.4/includes/parser/Parser.php(321): Parser->internalParse('This page has b...')
#8 /opt/mediawiki-1.13.4/includes/OutputPage.php(528): Parser->parse('This page has b...', Object(Title), Object(ParserOptions), true, true, 446)
#9 /opt/mediawiki-1.13.4/includes/GlobalFunctions.php(616): OutputPage->parse('This page has b...', true, true)
#10 /opt/mediawiki-1.13.4/includes/SkinTemplate.php(337): wfMsgExt('viewcount', Array, '437')
#11 /opt/mediawiki-1.13.4/includes/OutputPage.php(821): SkinTemplate->outputPage(Object(OutputPage))
#12 /opt/mediawiki-1.13.4/includes/Wiki.php(337): OutputPage->output()
#13 /opt/mediawiki-1.13.4/index.php(94): MediaWiki->finalCleanup(Array, Object(OutputPage))
#14 {main}
Comment 1 Aaron Schulz 2009-02-11 15:20:45 UTC
Probably due to an outdated message cache
Comment 2 miguelf 2009-02-11 15:32:16 UTC
(In reply to comment #1)
> Probably due to an outdated message cache
> 

If this is the case, how would one clear the message cache or re-generate it?
Comment 3 Aaron Schulz 2009-02-11 15:35:35 UTC
Really it *should* do so automatically; this is a recurring issue...
Comment 4 Aaron Schulz 2009-02-11 16:08:48 UTC
Should be fixed in r47143.
Comment 5 miguelf 2009-02-11 17:09:04 UTC
FWIW, I have added the changes to mediawiki-2.13.4 and it fixes the problem.
Comment 6 Aaron Schulz 2009-02-11 17:52:07 UTC
Closed.

Note: the count() check makes this retroactive (except for langs with fallbacks); otherwise a cache purge is needed.
Comment 7 Tim Starling 2009-06-22 16:59:17 UTC
(In reply to comment #4)
> Should be fixed in r47143.

I'm not sure why you think that would fix the problem. There's no data from MagicWord.php cached in the localisation cache, it will contain all magic words listed in the messages file regardless of whether they are listed elsewhere. The change you committed may well have destroyed Miguel's test case, because it would have cleared the localisation cache this one time, but there's no reason to think it would have fixed the underlying issue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links