Last modified: 2009-02-20 10:56:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19413, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17413 - Data returned by buildSidebar() is in wrong format
Data returned by buildSidebar() is in wrong format
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Collection (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: PediaPress Development Team
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-08 20:00 UTC by Thomas Bleher
Modified: 2009-02-20 10:56 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Thomas Bleher 2009-02-08 20:00:01 UTC
buildSidebar() returns a raw string to be included in the sidebar. This doesn't work with the DumpHTML extension, because it expects the format normally returned by Skin::buildSidebar(), which is built like this (line 1869 in includes/Skin.php):
  $bar[$heading][] = array(
                           'text' => $text,
                           'href' => $href,
                           'id' => 'n-' . strtr($line[1], ' ', '-'),
                           'active' => false
                          );

The Collection extension should be changed to return the same format.
Comment 1 PediaPress Development Team 2009-02-09 09:02:24 UTC
It's allowed for extensions to insert raw HTML instead of an array, see e.g. line 366 in skins/MonoBook.php in customBox():
<?php   } else {
			# allow raw HTML block to be defined by extensions
			print $cont;
		}
?>

Anayway, thanks for reporting: I looked at the sidebar building code and discovered that wfMsg() is later called on the heading, so we finally have the same id p-create_a_book ID for all languages. This is fixed in revision 47027.

Comment 2 Thomas Bleher 2009-02-20 10:56:57 UTC
Thanks for the fast response!
New bug submitted against DumpHTML: Bug 17586.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links