Last modified: 2010-05-15 15:48:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19402, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17402 - Hooks SkinAfterBottomScripts Not Executed
Hooks SkinAfterBottomScripts Not Executed
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.9.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-07 23:10 UTC by Nicolas BOUCHARD
Modified: 2010-05-15 15:48 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nicolas BOUCHARD 2009-02-07 23:10:48 UTC
Since several version the code of the function bottomScripts() has been modified :
the line 'wfRunHooks( 'SkinAfterBottomScripts', array( $this, &$bottomScriptText ) );' was erase and the hooks SkinAfterBottomScripts is now not executed.

I have resolve the problem on my mediawiki by restauring the old version of the function :

global $wgJsMimeType;
                $bottomScriptText = "\n\t\t<script type=\"$wgJsMimeType\">if (window.runOnloadHook) runOnloadHook();</script>\n";
                wfRunHooks( 'SkinAfterBottomScripts', array( $this, &$bottomScriptText ) );
                return $bottomScriptText;

I have show the problem when I have installed the Google Analytics Extension : http://www.mediawiki.org/wiki/Extension:Google_Analytics_Integration

BR
Nicolas
Comment 1 Nicolas BOUCHARD 2009-02-07 23:12:28 UTC
the function bottomScripts() is defined in the file include/Skin.php
Comment 2 Roan Kattouw 2009-02-09 14:10:51 UTC
Reassigning: not a bug in the bot API.
Comment 3 Alexandre Emsenhuber [IAlex] 2010-04-03 18:49:17 UTC
This hook is working fine on current MediaWiki version.
Note: it was added in 1.11, so it is no present in 1.9 (this what you put in the version field of this report).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links