Last modified: 2010-09-11 01:53:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19398, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17398 - Allow Image link= parameter when using thumb or frame
Allow Image link= parameter when using thumb or frame
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 19343 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-07 13:10 UTC by Alan Barrett
Modified: 2010-09-11 01:53 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alan Barrett 2009-02-07 13:10:09 UTC
The link= parameter in an image is ignored, if the image has a caption.  For example, [[Image:Example.png|link=Main Page|alt=Alt text|thumb|Caption goes here]] does not link to [[Main Page]], it links to [[File:Example.png]].  See [[Wikipedia:Images linking to articles]] at en.wikipedia.org for a demonstration.
Comment 1 MZMcBride 2009-02-08 03:09:47 UTC
This is caused by using 'thumb'. Summary updated accordingly.
Comment 2 Emufarmers 2009-07-01 03:47:09 UTC
Using "frame" causes the same problem; summary updated.
Comment 3 Subfader 2009-07-04 04:26:10 UTC
It is not ment to work with thumbs or frames. no bug here!
Comment 4 MZMcBride 2009-07-05 20:23:06 UTC
(In reply to comment #3)
> It is not ment to work with thumbs or frames. no bug here!

What? Re-opening pending further explanation.
Comment 5 Derk-Jan Hartman 2009-07-05 21:19:40 UTC
Well it isn't. Basically, it's designed to solve the issue with the protection icon link issue. The concern with adding it to other (frame/thumb) modes, was that part of our image "attribution" policy relies on an image to link to their description page, with full author and licensing information. The developers wanted to prevent that images are being included without a proper way to reach this information. (This is off the top of my head, i might be wrong).
Comment 6 Subfader 2009-07-05 22:52:37 UTC
Can't recall the dev I've chatted with about this issue on IRC (maybe Splarka) and he was very clear: thumbs should ALWAYS link to the image. Meanwhile I accept it, although I wish it was possible in galleries :)
Comment 7 Splarka 2009-07-06 04:16:37 UTC
I ain't no dev, but it is intentional. Changing severity to enhancement and rewording summary.
Comment 8 Michael Daly 2009-07-06 14:20:07 UTC
I can understand the logic for not permitting "link=" for thumbs (as explained in the log of IRC from March 1, 2009, but I've seen no explanation of why "link=" is forbidden for frame.  WHat would be the consequences of making this change to frame?
Comment 9 Michael Daly 2009-07-06 18:38:06 UTC
Referring to that IRC chat (http://toolserver.org/~amidaniel/chanlogs/%23mediawiki/20090301.txt), faking the thumb was the recommended workaround (using a <div to set a size etc). Faking a frame obviously does the same sort of thing.  Hence it is relatively trivial to override the intended restriction on the use of thumb.

It seems to me that this faking just adds complexity to the situation (for the user) whereas just providing the capability would allow the user to do what they want to do without adding complexity. 

If the objection is to using thumb in this manner as a way of removing access to the image's page with the attribution and copyright information and since it appears that the "link=..." functionality is done by invoking ImageMap in some way (an error can invoke an ImageMap error message - hence my assumption) it seems to me that this feature should use an additional capability of ImageMap and just put the info icon (i in a circle) onto the image with the link to the image's page provided by clicking on the info icon.  This would provide full use of the "link=..." feature for all extended image options without loss of direct access to the image's page.  From the user's perspective, we get less complexity all around and a more consistent rule for the feature's use.
Comment 10 Subfader 2009-07-07 20:49:20 UTC
yeah just link the magnify-clip.png in the caption to the image page if link= is used. good idea.
Comment 11 Subfader 2009-07-17 18:29:52 UTC
*** Bug 19343 has been marked as a duplicate of this bug. ***
Comment 12 Scott 2010-09-02 00:38:48 UTC
Can I just clarify the behaviour after the intended change - for images using 'frame' e.g. [[File:A030280.jpg|frame|270px|link=http://mysite]], clicking on the image will take the user to http://mysite and the magnify icon will take them to the image in MediaWiki?
Comment 13 Bawolff (Brian Wolff) 2010-09-09 17:31:10 UTC
I'm marking this works for me, as it works for me on latest svn. (It doesn't work on 'pedia, so presumably it was fixed sometime after the last major code update)
Comment 14 Emufarmers 2010-09-11 01:53:40 UTC
This was fixed in r69597.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links