Last modified: 2009-02-17 19:04:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19392, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17392 - in Title::isValidMoveTarget, $dbw->selectRow should pass array, not string
in Title::isValidMoveTarget, $dbw->selectRow should pass array, not string
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.12.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-06 23:49 UTC by Robert Fleming
Modified: 2009-02-17 19:04 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robert Fleming 2009-02-06 23:49:24 UTC
It seems to me that:

  'FOR UPDATE'

should be:

  array('FOR UPDATE')

in Title::isValidMoveTarget.  Database::selectRow seems to expect an array, not a string.  I get warnings (errors?) in my HTML when using the ReplaceText extension if I do not make this patch.

Thanks.
Comment 1 Robert Fleming 2009-02-07 00:11:26 UTC
There are other places in Title.php where $options is a string and is then passed to various methods of the Database class.  Dynamic typing strikes back...
Comment 2 Chad H. 2009-02-17 19:04:04 UTC
Done in Title and File in r47374

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links