Last modified: 2009-02-02 21:15:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19323, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17323 - CodeReview comments show useless 'reply' link even if you have no permission to comment
CodeReview comments show useless 'reply' link even if you have no permission ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
https://secure.wikimedia.org/wikipedi...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-02 19:54 UTC by Brion Vibber
Modified: 2009-02-02 21:15 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2009-02-02 19:54:00 UTC
When not logged in so you don't have comment privs, the comment list on Special:Code is still showing 'reply' links on comments. These don't do anything useful when you have no comment privs, since a form doesn't get shown to you.

The links should probably be hidden when no comment privs; alternately they could display a "you need to log in" message if it's sensible (but note historic issues with special page params on the returnto link from the login form... make sure it gets you back to someplace useful after!)
Comment 1 Aaron Schulz 2009-02-02 21:15:48 UTC
Hidden in r46735

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links