Last modified: 2014-11-16 03:50:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19291, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 17291 - MediaWiki:Nocontribs should pass on $target just like MediaWiki:Sp-contributions-footer
MediaWiki:Nocontribs should pass on $target just like MediaWiki:Sp-contributi...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Church of emacs
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-01-31 21:31 UTC by Church of emacs
Modified: 2014-11-16 03:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
added $target, changed to $wgOut->addWikiMsg( 'nocontribs', $target ); (17.17 KB, patch)
2009-01-31 21:31 UTC, Church of emacs 		Details
The actual diff for includes/specials/SpecialContributions.php (587 bytes, patch)
2009-01-31 21:44 UTC, Church of emacs 		Details
Patch changing SpecialContributions and system messages (1.79 KB, patch)
2009-01-31 22:16 UTC, Church of emacs 		Details
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Description Church of emacs 2009-01-31 21:31:47 UTC 
Created attachment 5760 [details]
added $target, changed to $wgOut->addWikiMsg( 'nocontribs', $target );

Currently it is possible to use $target on MediaWiki:Sp-contributions-footer to link to external tools that evaluate the user's contributions. This of course does not make sense when the user did not contribute anything. However, there are few tools that are also useful in that situation: Editcount of deleted edits and on Wikimedia projects a link to sulutil http://toolserver.org/~vvv/sulutil.php (possibly the user has to be blocked, so a link to sulutil and global user contributions might be useful).

The attached patch should fix it. It is my first bug fix (minor, I know, but everybody starts small).
Comment 1 Niklas Laxström 2009-01-31 21:36:40 UTC 
Can you make it in a patch format? svn diff or diff in linux, or some svn client on windows can do that.
Comment 2 Church of emacs 2009-01-31 21:44:35 UTC 
Created attachment 5761 [details]
The actual diff for includes/specials/SpecialContributions.php

Sorry. As I said, my first patch ;-)
I hope this is better...
Comment 3 Church of emacs 2009-01-31 22:16:16 UTC 
Created attachment 5762 [details]
Patch changing SpecialContributions and system messages

Added some changes to messages.inc and MessagesEn.php
Comment 4 Chad H. 2009-02-24 23:13:28 UTC 
Done in r47770
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links