Last modified: 2009-02-02 16:30:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19283, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 17283 - Double URL escaping in show/hide links for log entries
Double URL escaping in show/hide links for log entries
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page deletion (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-01-31 17:11 UTC by Mormegil
Modified: 2009-02-02 16:30 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Simple patch fixing the bug (670 bytes, patch)
2009-01-31 17:11 UTC, Mormegil 		Details
Patch fixing both occurrences of the bug (1.38 KB, patch)
2009-01-31 17:21 UTC, Mormegil 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Mormegil 2009-01-31 17:11:22 UTC 
Created attachment 5754 [details]
Simple patch fixing the bug

LogEventsList::getShowHideLinks uses Title::getPrefixedUrl, but the result is URL-encoded once again after it is passed through Skin::revDeleteLink. Title:getPrefixedDBkey should be used instead (c.f. PageHistory::historyLine).

This is probably not a problem for English-language wikis (since Special:Log does not have any escaped characters), but e.g. for a Czech-language wiki, that breaks the link (since Speciální:Log is double-encoded to Speci%25C3%25A1ln%25C3%25AD%3ALog).
Comment 1 Mormegil 2009-01-31 17:21:46 UTC 
Created attachment 5755 [details]
Patch fixing both occurrences of the bug

Oh, and while we are at it, the same bug is on another place: RevisionDeleteForm::__construct

And, in this case, it affects even English-language wikis, I believe, since the doubly-escaped string is a title of any random page.
Comment 2 Siebrand Mazeland 2009-02-02 16:30:14 UTC 
Applied in r46714. Thanks.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links