Last modified: 2009-06-01 04:31:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19275, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17275 - Deadlock FlaggedRevision::insertOn while saving a page
Deadlock FlaggedRevision::insertOn while saving a page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
http://de.wikipedia.org/wiki/1972
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-31 12:48 UTC by Thomas Goldammer
Modified: 2009-06-01 04:31 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Thomas Goldammer 2009-01-31 12:48:06 UTC
I tried to revert an article to http://de.wikipedia.org/w/index.php?oldid=56071336 which was a bot revision, thus auto-flagged (if that matters). I got 

aus der Funktion „FlaggedRevision::insertOn“. MySQL meldete den Fehler „1213: Deadlock found when trying to get lock; Try restarting transaction (10.0.6.23)“.

Best regards,
Th.

(p.s. if this is too similar to an existing bug, just add it there or drop me a note and I do it.)
Comment 1 Aaron Schulz 2009-01-31 18:22:30 UTC
Some tweaks in r46650 to make this less likely, but deadlocks will happen with mysql on occasion. It's not an issue unless it happens all the time. 
Comment 2 forrester.wikipedia 2009-04-23 20:57:24 UTC
While running a javascript-userscript this error occurs frequently (when there are more than 3-4 calls) which at least for german wikipedia's file checking team is a quite problematic behaviour. And since there is no machine-readable 500-errormessage we cannot identify that case and do the call again. Any idea to solve this?
Comment 3 Aaron Schulz 2009-04-25 00:35:24 UTC
What does the script do?
Comment 4 Aaron Schulz 2009-04-25 02:06:57 UTC
Some tweaks in r49851
Comment 5 forrester.wikipedia 2009-04-25 08:39:30 UTC
http://de.wikipedia.org/wiki/Benutzer:Forrester/d%C3%BCp-monobook.js

It changes some informations on several file-pages that are needed for our file checking project to do not lose files (e.g. http://de.wikipedia.org/w/index.php?title=Datei:Bhopalkart.jpg&diff=prev&oldid=59390404)

And when there are many file-pages to change at one action some are not done:

At those which are not changed firebog does not list the GET calls and the POST calls (action: submit) comprise:

<!-- start content -->
			Es ist ein Datenbankfehler aufgetreten.
Der Grund kann ein Timeout sein, der Ausfall eines Servers oder auch ein Programmierfehler.
Die letzte Datenbankabfrage lautete: <blockquote><tt>(SQL-Abfrage versteckt)</tt></blockquote> aus der Funktion „<tt>FlaggedRevision::insertOn</tt>“.
MySQL meldete den Fehler „<tt>1213: Deadlock found when trying to get lock; Try restarting transaction (10.0.6.23)</tt>“.
Comment 6 Siebrand Mazeland 2009-04-25 08:44:00 UTC
Update synopsis
Comment 7 Aaron Schulz 2009-04-26 01:06:50 UTC
Tweaks in r49851, r49889
Comment 8 forrester.wikipedia 2009-04-26 09:03:57 UTC
And do you think that this could solve the problem? One alternative that I was told to present would be to make this error machine-readable (error 500) so that if it occurs a userscript could send the call again.
Comment 9 Aaron Schulz 2009-04-26 09:32:40 UTC
Is this using the API or doing a RevisionReview hit like the UI does?
Comment 10 forrester.wikipedia 2009-04-29 17:57:02 UTC
it's not using the API, it's emulating the UI using action=edit and submitting shortly afterwards. 
Comment 11 forrester.wikipedia 2009-05-08 21:18:10 UTC
Can I expect some improvements or is this problem non-changeable?
Comment 12 Aaron Schulz 2009-05-09 01:06:44 UTC
Changes have been made, but not synced.
Comment 13 forrester.wikipedia 2009-05-09 06:33:50 UTC
And do you think that those changes solve the problem or make it less likely to occur?
Comment 14 Tim Starling 2009-05-26 05:00:31 UTC
As I said on CodeReview, I believe the use of LOCK IN SHARE MODE will make this bug happen more, rather than less. Deadlocks can be avoided completely by just not using locking reads.
Comment 15 Aaron Schulz 2009-06-01 04:31:28 UTC
Fixed in r51269

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links