Last modified: 2010-05-15 15:37:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1714 - Spaces between "Save page", "Show preview" and "Show changes" buttons are too small
Spaces between "Save page", "Show preview" and "Show changes" buttons are too...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.5.x
PC All
: Normal trivial with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-19 18:26 UTC by Tomer Chachamu
Modified: 2010-05-15 15:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of problem as seen from an admin account (1024x768) (99.04 KB, image/png)
2005-03-19 18:31 UTC, Tomer Chachamu
Details

Description Tomer Chachamu 2005-03-19 18:26:06 UTC
With the addition of the "Show changes" button, the line of buttons now looks a
bit confusing. (Will upload screenshot)

Possible solutions include bolding the "Save page" button and adding (for
example) an em space (   or   or   ) after the "Save page"
button to separate it from the less important buttons.
Comment 1 Tomer Chachamu 2005-03-19 18:31:23 UTC
Created attachment 374 [details]
Screenshot of problem as seen from an admin account (1024x768)

Mozilla Firefox 1.0.1 on Windows XP. Developer toolbar accidentally left in.
Comment 2 Antoine "hashar" Musso (WMF) 2005-03-30 09:27:45 UTC
  commited to head. Thanks :o)
Comment 3 Tomer Chachamu 2005-05-09 23:03:12 UTC
Problem still appears on FiverAlpha.
Comment 4 Ævar Arnfjörð Bjarmason 2005-05-09 23:07:54 UTC
(In reply to comment #2)
>   commited to head. Thanks :o)

Ashar, I removed that space a few days ago ( in version 1.165 ), first of all it
looks like crap in some browsers, namely Konqueror and css is the right place to
do this, if you really want to add a margin on that button please do so in CSS
where it belongs.
Comment 5 Tomer Chachamu 2005-05-28 14:12:06 UTC
Well, will anybody make this change?

Here's the addition to main.css (for Monobook):

#wpSave {
        margin-right: 1em;
}
Comment 6 Tomer Chachamu 2005-05-28 14:13:07 UTC
Forgot to mention that the exact same thing can be used for any other skin.
Users can also put it in their own /Monobook.css file as I will.
Comment 7 Ævar Arnfjörð Bjarmason 2005-06-21 14:23:58 UTC
(In reply to comment #5)
> Here's the addition to main.css (for Monobook):
> 
> #wpSave {
>         margin-right: 1em;
> }

Why put a space between the save and preview buttons? It wasn't like that in 1.4.

Furthermore, why have a space between them at all? WONTFIX?

Comment 8 Tomer Chachamu 2005-06-21 14:46:13 UTC
Well, I felt that with the addition of "Show pages" the whole thing looked too
crammed. It's the logical place to distance the three buttons.
Comment 9 Ævar Arnfjörð Bjarmason 2005-06-21 15:18:08 UTC
(In reply to comment #8)
> Well, I felt that with the addition of "Show pages" the whole thing looked too
> crammed. It's the logical place to distance the three buttons.

You're right, I put a 1em right margin to #wpSave in HEAD as you suggested,
marking this as FIXED.
Comment 10 Zigger 2005-06-21 15:36:05 UTC
I prefer the following CSS for monobook/main.css, and it happens to match the IE
default.  Firefox uses smaller internal and external margins, which is where I
see the problem.  N.B. The CSS needs to be margin-left in monobook/rtl.css.

input#wpSave, input#wpPreview, input#wpDiff {
   margin-right: 0.33em;
}
Comment 11 Ævar Arnfjörð Bjarmason 2005-06-21 15:41:47 UTC
(In reply to comment #10)
> I prefer the following CSS for monobook/main.css, and it happens to match the IE
> default.  Firefox uses smaller internal and external margins, which is where I
> see the problem.  N.B. The CSS needs to be margin-left in monobook/rtl.css.
> 
> input#wpSave, input#wpPreview, input#wpDiff {
>    margin-right: 0.33em;
> }
> 

Applied

input#wpSave, input#wpDiff {
        margin-right: 0.33em;
}  

To HEAD, that way the "Show preview" and "Show changes" buttins are grouped
togather.
Comment 12 Zigger 2005-06-21 15:50:19 UTC
(In reply to comment #11)
> (In reply to comment #10)
I was wrong about IE, due to an IE6 CSS bug during a previous test.

Thanks for the prompt commit Ævar, but can you do monobook/rtl.css as well?
Comment 13 Ævar Arnfjörð Bjarmason 2005-06-21 16:08:38 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> I was wrong about IE, due to an IE6 CSS bug during a previous test.
> 
> Thanks for the prompt commit Ævar, but can you do monobook/rtl.css as well?

Can you provide a patch? I find thinking in ltr terms mind boggling.
Comment 14 Zigger 2005-06-21 16:15:31 UTC
(In reply to comment #13)
This can be added to the bottom of monobook/rtl.css :

input#wpSave, input#wpDiff {
        margin-left: 0.33em;
}
Comment 15 Zigger 2005-06-21 16:54:26 UTC
(In reply to comment #14)
> (In reply to comment #13)
> This can be added to the bottom of monobook/rtl.css :
Corrected to override main.css:

input#wpSave, input#wpDiff {
        margin-right: 0;
        margin-left: 0.33em;
}

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links