Last modified: 2012-10-15 13:54:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19124, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17124 - Link to log of a .pdf file should not have PDF icon
Link to log of a .pdf file should not have PDF icon
Status: NEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks: css 41037
  Show dependency treegraph
 
Reported: 2009-01-23 02:13 UTC by Gurch
Modified: 2012-10-15 13:54 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gurch 2009-01-23 02:13:01 UTC
At the moment all links that end in ".pdf" seem to get the PDF icon. This is OK for links to external sites, but MediaWiki ought to be smart enough to use the correct icon when linking to elsewhere on the same wiki.

Thus a link like http://en.wikipedia.org/w/index.php?title=Special:Log&page=File:4chan_raid.pdf should not be rendered with a PDF icon.
Comment 1 Chad H. 2009-01-23 02:51:47 UTC
Why shouldn't it? It's a PDF file and it's not formatted as an internal link.
Comment 2 Danny B. 2009-01-23 04:52:32 UTC
(In reply to comment #1)
> Why shouldn't it? It's a PDF file and it's not formatted as an internal link.

In fact it is *not* PDF file but XHTML - it doesn't point to PDF file itself, but to the log page of that file. It should have the standard "arrow-out" icon then.
Comment 3 Brion Vibber 2009-01-31 01:25:00 UTC
This is a tricky thing to deal with -- you can't *actually* tell from a URL what the file type is going to be. :)

In theory a better selector could distinguish between the whole URL and the path before the query string ending in ".pdf", but I'm not sure how convenient that is... and it'll still give you false matches in cases like a link to a File: page.
Comment 4 Gurch 2009-06-23 22:28:58 UTC
(In reply to comment #3)
> This is a tricky thing to deal with -- you can't *actually* tell from a URL
> what the file type is going to be. :)

Yeah... a true solution to this would probably be a way to link to internal pages without using the external link syntax (which I'm sure has already been requested elsewhere). This just caught my attention at one point.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links