Last modified: 2014-11-20 15:17:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19108, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17108 - Make "Hide" Cookies notice independent
Make "Hide" Cookies notice independent
Status: ASSIGNED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Matt Walker
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-21 20:04 UTC by Casey Brown
Modified: 2014-11-20 15:17 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Casey Brown 2009-01-21 20:04:41 UTC
Please allow the option for the "hide"/"dismiss" cookie to be notice independent (ie. if you close one notice, they don't all close).
Comment 1 Ryan Kaldari 2011-01-06 01:39:16 UTC
This would take a fair bit of work, but is doable I think. I'm imagining a checkbox on the banner editing interface that says "Make hide/show toggle specific to this banner only". We would probably want to create separate cookies for the banner-specific cases and then update BannerController to look for those if the banner has the corresponding flag in the db table.
Comment 2 Marcin Cieślak 2011-03-12 03:00:16 UTC
There is a discussion in bug 16821 that goes into the opposite direction - one cookie to hide all notices down, cross-wiki.
Comment 3 Ryan Kaldari 2011-06-08 23:59:43 UTC
Now that we can identify banners as "fundraising banners", we could easily assign them a separate cookie. This would allow people to keep seeing normal banners, but hide all the fundraising banners. It's not a full solution to this bug, but it would take care of one of the major cases.
Comment 4 Ryan Kaldari 2011-08-16 23:32:26 UTC
This is now fixed for fundraising banners - they are considered a separate group for the purposes of banner hiding.
Comment 5 Krinkle 2011-12-07 21:10:48 UTC
So for the future we'd want:
* default to let cooking-hiding hide all banners within the current compaign
* option to let hide only hide the current banner within the compaign
and also cool:
* let the banner controller that chooses the banners skip ones hidden by cookie, so that others get more exposure (by removing chances of user getting a banner that is then directly hidden).
Comment 6 varnent 2012-01-04 22:23:32 UTC
Not to muck things up even more - but what about the ability or option to use some sort of DB tag for users logged in that click to dismiss?  With an increasing number of folks (I presume - could be wrong) using multiple devices and multiple WMF projects - would be handy if this was user specific rather than site/cookie/pc specific.  You click dismiss on enWP and it disappears on all your WMF projects with that login - regardless of what device.  Might also be handy if banners on mobile devices is ever a plan for the future.
Comment 7 Ryan Kaldari 2012-01-25 01:37:54 UTC
@varnent: Your suggestion is a combination of bug 33941 and bug 14950.

@all: Now that banners are separated into fundraising and non-fundraising banners, I think that takes care of most of the issue. I'm reluctant to create more atomic control over banner cookies, as such a feature would surely be used (abused) by most everyone creating banners.

There may be an argument, however, for creating a 3rd banner group for "emergency banners", i.e. banners that everyone should see regardless of whether they have dismissed other banners. This would be fairly simple to implement as it would just be a 3rd cookie name. Thoughts?
Comment 8 Matt Walker 2012-08-09 21:30:29 UTC
With the new Z level enhancement it seems reasonable that we can implement the 'emergency' no dismiss only for banners on the 'emergency' level. We probably don't even need a cookie: we just notice that the banner is at that level and never allow it to be dismissed?
Comment 9 Matt Walker 2013-07-30 01:31:11 UTC
https://gerrit.wikimedia.org/r/#/c/71751/ implements the don't hide emergency banners part.
Comment 10 Matt Walker 2013-07-30 01:31:59 UTC
And this is also mingle card https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/980
Comment 11 Bartosz Dziewoński 2013-08-20 20:39:28 UTC
Of note, casual use of "emergency" level caused bug 53116.
Comment 12 Andre Klapper 2014-11-20 15:17:00 UTC
(In reply to Matt Walker from comment #9)
> https://gerrit.wikimedia.org/r/#/c/71751/ implements the don't hide
> emergency banners part.

That patch was merged a year ago.

Matt Walker: This issue has been assigned to you a while ago. Are you still working (or still plan to work) on this issue? Only in case you do not plan to work on this issue anymore, should the assignee be set back to default? Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links