Last modified: 2009-01-27 05:01:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19104, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17104 - Remove [Mark as patrolled] link for already patrolled revisions
Remove [Mark as patrolled] link for already patrolled revisions
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-21 18:44 UTC by Jon Harald Søby
Modified: 2009-01-27 05:01 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon Harald Søby 2009-01-21 18:44:54 UTC
In the IRC channels the links to diffs include an &rcid= part, which was used to enable patrolling from it I guess. However, when I click any diff now it shows a [Mark as patrolled] link, even for edits admins and autopatrolled users. This makes it kind of pointless. And since this part was added to the links, [Mark as patrolled] links have started appearing even when there is no &rcid= (when the revision is not patrolled) from Special:Recentchanges. In othec words, the rcid part of the URL is superfluous, and should be removed because it decreases the usability of the links.

Sorry for not being able to explain it better, but I hope I got the meaning across.
Comment 1 Gurch 2009-01-21 18:59:24 UTC
Wouldn't it be better to fix the other end of the issue, and not show the "mark as patrolled" link on diffs if the edit is already patrolled, regardless of what's in the URL?

I asked for the rcid part to be added in order that bots and editing tools (the main consumers of the RC feed) are able to patrol (and sight) pages. Before it was added, it was difficult to obtain this value when all you had was a page name or revision ID. It was particularly difficult for new page patrolling -- the only place the rcid was actually shown was on Special:Newpages, or on article pages arrived at by following links from Special:Newpages. This meant that in order to patrol a given page, the tool would have to load up special:newpages and scrape the rcid from it... unless the page wasn't in the top however many, in which case it would have to load more and more of it, or give up.

If this is removed, please provide some alternative method for bots and editing tools to obtain the rcid given a revision id.
Comment 2 Jon Harald Søby 2009-01-21 19:28:36 UTC
Ah, I understand. The bug should then instead be "Remove [Mark as patrolled] link for already patrolled revisions"; changing title to reflect that. Note that it is only an issue when &rcid= is provided.
Comment 3 Jon Harald Søby 2009-01-21 19:30:11 UTC
I filed it as part of the Patroller extension; however, I am not sure that's correct, as that extension does nat show up at http://no.wikipedia.org/wiki/Spesial:Versjon . Is the patrol feature a part of MediaWiki core now?
Comment 4 Gurch 2009-01-21 19:32:35 UTC
Yes, it is part of core. There doesn't seem to be a "patrolling" component, though, so I put it under "User interface".
Comment 5 Aaron Schulz 2009-01-24 22:50:45 UTC
Done in r46171
Comment 6 Brion Vibber 2009-01-26 23:17:17 UTC
Release notes?
Comment 7 Aaron Schulz 2009-01-27 05:01:17 UTC
closed

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links