Last modified: 2011-01-25 00:03:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19103, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17103 - Special:Newpages/Special:Recentchanges should be localized on the "mark changes as patrolled" confirmation
Special:Newpages/Special:Recentchanges should be localized on the "mark chang...
Status: VERIFIED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.15.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-21 13:04 UTC by Marcin Cieślak
Modified: 2011-01-25 00:03 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to includes/Article.php to add wfMsg() where necessary (2.09 KB, patch)
2009-01-21 13:04 UTC, Marcin Cieślak
Details
Patch to includes/Article.php to add wfMsg() where necessary (really this time) (550 bytes, patch)
2009-01-31 20:31 UTC, Marcin Cieślak
Details
Capitalize special page names (532 bytes, patch)
2009-02-15 22:32 UTC, Marcin Cieślak
Details

Description Marcin Cieślak 2009-01-21 13:04:01 UTC
Created attachment 5714 [details]
Patch to includes/Article.php to add wfMsg() where necessary

1) Enable patrolling
2) Edit as non-autopatrol user
3) Switch to the patrolling user
4) Switch user interface to non-English
5) Mark the change as patrolled
6) The confirmation message:

"Return to Special:Recentchanges" says

"Powrót do Specjalna:Recentchanges" in Polish.

This means, that Title::MakeTitle provides localized namespace name, but no the page name.

The fix is trivial I guess, see the patch attached.
Comment 1 Niklas Laxström 2009-01-31 17:07:03 UTC
Patch does not seem correspond to the bug description. Maybe wrong patch?
Comment 2 Marcin Cieślak 2009-01-31 20:31:28 UTC
Created attachment 5758 [details]
Patch to includes/Article.php to add wfMsg() where necessary (really this time)

Oh, yes, the attachment fixes bug 2557, not this one.

Updated - sorry for my mistake.
Comment 3 Niklas Laxström 2009-01-31 21:27:07 UTC
Thanks, fixed in r46659. I had to use a method of SpecialPage though.
Comment 4 Marcin Cieślak 2009-02-15 22:32:22 UTC
Created attachment 5819 [details]
Capitalize special page names

Well, one needs to capitalize special page names to work this way.
Comment 5 Marcin Cieślak 2009-02-15 22:33:20 UTC
Tested in r47298, still does not work, please see the second patch.
Comment 6 Niklas Laxström 2009-02-21 10:41:54 UTC
Fix applied in r47607.
Comment 7 Marcin Cieślak 2009-02-21 13:00:09 UTC
Tested, works as of r47611. Thank you very much!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links