Last modified: 2011-01-25 00:29:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19084, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17084 - E-mail notifications are sent on every change (currently a wrong behaviour)
E-mail notifications are sent on every change (currently a wrong behaviour)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
1.14.x
All All
: Highest major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 10172
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-19 23:13 UTC by T. Gries
Modified: 2011-01-25 00:29 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2009-01-19 23:13:10 UTC
I noticed that - since a couple of days - e-mail notifications (enotifs) are sent to me for every change on my watched pages on 

- http://www.mediawiki.org/ and
- http://commons.wikimedia.org/

Enotif is designed to send only a single e-mail notification for the first unseen change and further e-mails are suppressed until I visit that watched page.

Perhaps a database problem ?
Comment 1 T. Gries 2009-01-20 14:48:19 UTC
I increased the severity level, because this function is still misbehaving for an unknown reason, as it currently sends for every change of watched pages (if the user has opted-in to email and email notification).

Current version http://www.mediawiki.org/wiki/Special:Version is 1.14alpha 
Comment 2 Aaron Schulz 2009-01-24 18:29:36 UTC
20:31 brion: putting $wgEnotifUseJobQ back for now. change postdates some of the spikes i'm seeing, but it'll be easier to not have to consider it
...
17:38 brion: ~1-hour lag on db3 

...Notifications switched to job queue recently. Since the queue FIFO, it shouldn't cause issues. Slave lag however, can cause problems with wl_notificationtimestamp being stuck as NULL.
Comment 3 Aaron Schulz 2009-01-24 22:41:12 UTC
Made some tweaks in r46156, r46158. Not sure what the exact issue is here. 
Comment 4 T. Gries 2009-01-24 22:43:11 UTC
(In reply to comment #3)
> Made some tweaks in r46156, r46158. Not sure what the exact issue is here. 
> 

I'll have a look, try to check and understand them (I designed e-notif some years ago)

Comment 5 T. Gries 2009-01-25 21:07:41 UTC
I still receive enotifs for each change of a page. Here are recent examples with the relevant mail headers for your analysis.
Increased bug priority.

*** First enotif:

Date: Sun, 25 Jan 2009 19:39:36 GMT
Message-Id: <200901251939.n0PJdark032537@localhost.localdomain>

the MediaWiki page Project:Developer meet-up 2009 has been changed on
16:57, 25 January 2009 by HardDisk, ...
http://www.mediawiki.org/w/index.php?title=Project:Developer_meet-up_2009&diff=0&oldid=234615


*** Second enotif for the same page

Date: Sun, 25 Jan 2009 19:39:41 GMT
Message-Id: <200901251939.n0PJdfPD032610@localhost.localdomain>
...
the MediaWiki page Project:Developer meet-up 2009 has been changed on
19:06, 25 January 2009 by ThomasV, ...
http://www.mediawiki.org/w/index.php?title=Project:Developer_meet-up_2009&diff=0&oldid=234676
Comment 6 Aaron Schulz 2009-01-25 23:34:18 UTC
Nobody synced any code, so it will still be the same :)
Comment 7 T. Gries 2009-01-26 08:01:25 UTC
(In reply to comment #5)

Mail header: Sun, 25 Jan 2009 19:39:36 GMT
Page was changed on 16:57, 25 January 2009 by HardDisk, ...

*** Second enotif for the same page
Mail header: Sun, 25 Jan 2009 19:39:41 GMT
Page was changed on 19:06, 25 January 2009 by ThomasV, ...

Analysis:
Both enotifs were sent at the same minute 19:39, whereas the triggering page changes were committed at 16:57 respectively 19:06 - perhaps this indicates that the wrong databases are used (master/slave) in Enotif, or that the lagging between them needs now to be compensated by redesigning the e-notif software in /includes/UserMailer.php . 

Perhaps a help to find what has been changed (but should not): Enotif worked without any glitches until first week of January 2009.

Sorry, I cannot change software and don't have the necessary skills to understand the master/slave mechanism of the current version, job for Tim or Brion ?
Comment 8 Roan Kattouw 2009-03-02 16:30:41 UTC
This looks like a dupe of bug 17620, marking it as such. It *may* be caused by bug 10172 as well.

*** This bug has been marked as a duplicate of bug 17620 ***
Comment 9 Tim Starling 2009-03-17 08:14:22 UTC
Not a dupe of 17620, but most likely the same as 10172 and thus fixed at the same time.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links