Last modified: 2009-05-30 06:56:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19018, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17018 - Automated smallest-CIDR calculation from within Checkuser UI
Automated smallest-CIDR calculation from within Checkuser UI
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CheckUser (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-14 08:51 UTC by Mark Pellegrini
Modified: 2009-05-30 06:56 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Pellegrini 2009-01-14 08:51:36 UTC
There should be a feature within the checkuser interface to automatically calculate the smallest CIDR necessary to block some given set of IPs. Manually calculating it is time-consuming and error-prone.
Comment 1 Aaron Schulz 2009-02-13 00:22:45 UTC
Can any of the IPs in the list be a CIDR?
Comment 2 Mike.lifeguard 2009-02-13 00:26:19 UTC
(In reply to comment #0)
> There should be a feature within the checkuser interface to automatically
> calculate the smallest CIDR necessary to block some given set of IPs. Manually
> calculating it is time-consuming and error-prone.
> 

There is a tool on the toolserver you can use until this is done: http://toolserver.org/~chm/blockcalc.php
Comment 3 Aaron Schulz 2009-02-13 19:28:42 UTC
(In reply to comment #1)
> Can any of the IPs in the list be a CIDR?
> 

Won't be too hard actually. Almost finished with the JS (for IPv4)
Comment 4 Aaron Schulz 2009-02-13 19:47:15 UTC
Done in r47226
Comment 5 Mike.lifeguard 2009-05-18 23:48:28 UTC
(In reply to comment #4)
> Done in r47226
> 

Any chance you could have this filter out only valid IPs/ranges from copy-pasted text akin to the tool linked in comment 2? This just makes it easier to copy and paste stuff from results (or page history or whatever) without having to manually make sure you've got only the IPs.
Comment 6 Aaron Schulz 2009-05-19 00:08:17 UTC
I tested copy-pasting the auto-WHOIS JS tool output and such when I wrote it. If there is another type of output that it doesn't filter out, you should paste out a sample so I know what to tweak.
Comment 7 Mike.lifeguard 2009-05-19 00:39:36 UTC
(In reply to comment #6)
> I tested copy-pasting the auto-WHOIS JS tool output and such when I wrote it.
> If there is another type of output that it doesn't filter out, you should paste
> out a sample so I know what to tweak.
> 

I think it was version numbers from the UA: 2.0.4.16 for example. It looks like an IP, but really that's not valid: http://toolserver.org/~chm/whois.php?ip=2.0.4.16

& forgot to reopen this previously.
Comment 8 Aaron Schulz 2009-05-19 19:05:07 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > I tested copy-pasting the auto-WHOIS JS tool output and such when I wrote it.
> > If there is another type of output that it doesn't filter out, you should paste
> > out a sample so I know what to tweak.
> > 
> 
> I think it was version numbers from the UA: 2.0.4.16 for example. It looks like
> an IP, but really that's not valid:
> http://toolserver.org/~chm/whois.php?ip=2.0.4.16
> 
> & forgot to reopen this previously.
> 

I'm not sure how simple it is to check for that.
Comment 9 Aaron Schulz 2009-05-30 06:56:13 UTC
Various fixes in r51179. Some reserved IPs treated as such.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links