Last modified: 2013-06-18 14:46:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18985, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 16985 - Special:Nuke shows always "1 edit"


Summary:	Special:Nuke shows always "1 edit"

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Nuke (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-01-12 07:38 UTC by Niklas Laxström
Modified:	2013-06-18 14:46 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Pulls the correct number of edits for an article (1.17 KB, patch) 2009-05-03 17:58 UTC, Nakon	Details
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2009-01-12 07:38:44 UTC

Special:Nuke shows always 1 edit for each listed page. I do not know exactly what the purpose is, but it is confusing. The query seems to try to count all edits by the user, but then filters only page creations with RC_NEW = 1, which of course leads to described results.

Comment 1 Nakon 2009-05-03 17:58:19 UTC

Created attachment 6084 [details]
Pulls the correct number of edits for an article

patch included

Comment 2 Niklas Laxström 2010-09-11 16:41:57 UTC

Is there way to do it without extra queries?

Comment 3 X! 2010-09-11 16:46:55 UTC

The patch is probably stale, considering Nuke has been in the MediaWiki core for a while.

Comment 4 Niklas Laxström 2010-09-11 17:07:21 UTC

I don't see it in the core, where is it?

Comment 5 X! 2010-09-11 17:09:11 UTC

Whoops, ignore that. It was in core from r41630 to r42117.

Comment 6 Sumana Harihareswara 2011-11-14 16:14:12 UTC

(In reply to comment #3)
> The patch is probably stale, considering Nuke has been in the MediaWiki core
> for a while.

Marking "need-review" just to absolutely check whether the patch is completely stale.

Comment 7 Nemo 2012-01-02 18:21:29 UTC

Bug still present in 1.18wmf1 r107379.

Comment 8 Jeroen De Dauw 2012-01-11 09:35:40 UTC

r108602 fixes this

Comment 9 Sumana Harihareswara 2012-01-11 13:01:28 UTC

Thanks for the patch, Nakon.

Comment 10 Sam Reed (reedy) 2012-01-13 23:31:35 UTC

Doing a query per row isn't very DB friendly, especially when it's not for much gain

Reverted in r108871

Comment 11 Marcin Cieślak 2012-03-12 00:20:12 UTC

I think I fixed this using one query in r113603.

Tested on both MySQL and PostgreSQL.

Comment 12 Jeroen De Dauw 2012-03-12 00:29:01 UTC

Tested on MySQL as well.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links