Last modified: 2009-01-09 13:12:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18936, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16936 - No space anymore between icon and text
No space anymore between icon and text
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Aaron Schulz
http://svn.wikimedia.org/viewvc/media...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-01-08 08:09 UTC by Melancholie
Modified: 2009-01-09 13:12 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
no space between icon and text (15.73 KB, image/png)
2009-01-09 08:10 UTC, Melancholie 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Melancholie 2009-01-08 08:09:17 UTC 
You have cropped the icon size from 18px to 16px, removing whitespace.
See
r1=44548&r2=45290&pathrev=45434">http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/FlaggedRevs/flaggedrevs.css?r1=44548&r2=45290&pathrev=45434
Now there is no space between the icon (fr-icon-xxx) and the following text (no id or class, by the way).

You could also make 'margin: 0em 0em 0em 1em;' to 'margin-left: 1em;', I think (not sure).

Furthermore you could crop all '0px' and '0em' to just '0'.
Comment 1 Aaron Schulz 2009-01-08 13:10:18 UTC 
Do we need this whitespace?
Comment 2 Melancholie 2009-01-09 08:10:18 UTC 
Created attachment 5654 [details]
no space between icon and text

Currently it looks like this.
Nicer would be to have a whitespace in between (~2px)
Is it a problem (bug 16811)?
Comment 3 Aaron Schulz 2009-01-09 13:12:50 UTC 
Done in r45597
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links