Last modified: 2011-01-25 01:33:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 16925 - Diffs silently fail when $wgExternalDiffEngine is set to 'wikidiff2' but extension is not installed
Diffs silently fail when $wgExternalDiffEngine is set to 'wikidiff2' but exte...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-07 20:27 UTC by Brion Vibber
Modified: 2011-01-25 01:33 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2009-01-07 20:27:40 UTC
Discovered this when wikitech was moved to new server; wikidiff2 had been set up as $wgExternalDiffEngine but the PHP extension hadn't been installed on the new machine.

Diffs failed silently, and were even saved blank into the diff cache. All edits appeared as thought here were no changes, more or less.

Should either show an error message, fall back to regular diff code, or some combination thereof; and should definitely not be saving bogus diffs into the cache!
Comment 1 Chad H. 2009-01-08 00:14:56 UTC
That seems really odd. DifferenceEngine *should* be failing back to native PHP diff implementation if it can't load/use wikidiff2.
Comment 2 Chad H. 2009-05-07 16:00:38 UTC
Fixed in r50310

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links