Last modified: 2009-05-17 13:38:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18912, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16912 - Missing tooltip of images (title="" not specified)
Missing tooltip of images (title="" not specified)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.14.x
All All
: Normal minor with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikipedia.org/w/index.php?t...
: easy, patch, patch-need-review
: 17044 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-06 23:42 UTC by WIKImaniac
Modified: 2009-05-17 13:38 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to set a's title= for [[Image:..|link=]] (1.30 KB, patch)
2009-05-13 23:29 UTC, Derk-Jan Hartman
Details

Description WIKImaniac 2009-01-06 23:42:11 UTC
case 1: No tooltip is shown:
[[Image:Qsicon Exzellent.svg|x16px|link=Wikipedia:Exzellente Artikel|tooltip]]

case 2: Tooltip is shown if there is no hyperlink:
[[Image:Qsicon Exzellent.svg|x16px|tooltip]]

case 3: Hyperlink an tooltip is shown:
<imagemap>
Image:Qsicon Exzellent.svg|x16px
default [[Wikipedia:Exzellente Artikel|tooltip]]
desc none
</imagemap>


I would prefer to get the result of case 3 by using syntax of case 1.
Comment 1 Siebrand Mazeland 2009-01-06 23:50:36 UTC
Case 3 is probably specific to [[mw:Extension:ImageMap]], while the first two use cases are in MediaWiki core.
Comment 2 Melancholie 2009-01-17 12:20:42 UTC
Note that, although alt="tooltip" is available in source code and thus probably shown as fallback tooltip with IEs, all other web browsers rely on title="tooltip" to be specified. But title="" is missing.
See https://bugzilla.wikimedia.org/show_bug.cgi?id=17044#c1
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-01-17 23:37:56 UTC
*** Bug 17044 has been marked as a duplicate of this bug. ***
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-01-17 23:42:06 UTC
The HTML for case 1 looks like

<a href="http://commons.wikimedia.org/wiki/" title="commons:"><img alt="Commons" src="http://upload.wikimedia.org/wikipedia/commons/9/9d/Commons-logo-31px.png" width="31" border="0" height="41"></a>

The unnamed parameter is eaten in favor of the default link tooltip.  This is wrong.  This is probably a simple change to Parser::makeImage() to fix; it might be necessary to look a couple of levels down at the stuff it calls.
Comment 5 Jody 2009-05-13 21:37:53 UTC
Any progress 5 months later on this issue?
Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-05-13 22:25:08 UTC
Apparently not.
Comment 7 Derk-Jan Hartman 2009-05-13 23:29:45 UTC
Created attachment 6116 [details]
Patch to set a's title= for [[Image:..|link=]]

I've been hunting around, and I think this patch should fix the problem. The code is untested, because i don't run a mediawiki installation, but should be easy to verify.
Comment 8 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-05-15 19:43:22 UTC
-			$linkAttribs = array( 'href' => $options['custom-url-link'] );
+			$linkAttribs = array( 'href' => $options['custom-url-link'], 'title' => $alt );

This wasn't right -- it was adding an empty title if the alt text was empty, which I don't think we want.  Other than that, it tested out fine.  Committed as r50641.
Comment 9 Jody 2009-05-16 02:13:54 UTC
So does that mean it's fixed? It's still not working at http://en.wikipedia.org/wiki/Template:Click/doc in the examples there.
Comment 10 Dan Wolff 2009-05-16 09:12:12 UTC
...which would be because Wikipedia isn't running r50641 yet, see [[Special:Version]] (currently at r48811).
But still, it will be available fairly soon.
Comment 11 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-05-17 13:38:23 UTC
It will be available (assuming all goes well) at the next scap, which may or may not be fairly soon.  The last scap was close to two months ago, and who knows when the next one will be.  But it should work when [[Special:Version]] gets to r50641 or later.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links