Last modified: 2009-01-14 16:18:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18849, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 16849 - recommended svn version for 1.13 is broken


Summary:	recommended svn version for 1.13 is broken

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Configure (Other open bugs)
Version:	unspecified
Hardware:	PC Linux

Importance:	Normal critical (vote)
Target Milestone:	---
Assigned To:	Alexandre Emsenhuber [IAlex]

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-12-31 12:27 UTC by Alon Swartz
Modified:	2009-01-14 16:18 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
patch for the above mentioned issues (1.43 KB, patch) 2008-12-31 12:29 UTC, Alon Swartz	Details
Add an attachment (proposed patch, testcase, etc.)

Description Alon Swartz 2008-12-31 12:27:34 UTC

Mediawiki: 1.13.3-1 (latest debian package)
Configure: 0.10.18 (svn revision 44430)

When attempting to "configure the wiki" or "view the configuration", the extension produces a fatal error rendering the extension unusable.

    Fatal error: Call to undefined method SkinMonoBook::link() 
    Warning: preg_match() expects parameter 2 to be string, array given

I assume the link() method is part of mediawiki 1.14.
My development experience in php is limited, but I have attached a patch that seems to have fixed the issues.
The solution:

    - replace the link() method with makeKnownLinkObj() in Configure.page.php and SpecialViewConfig.php
    - pass a string instead of an array when creating the action link in SpecialViewConfig.php

Cheers,
Alon

--
Website: http://www.turnkeylinux.org
Launchpad: https://launchpad.net/~alonswartz

Comment 1 Alon Swartz 2008-12-31 12:29:03 UTC

Created attachment 5633 [details]
patch for the above mentioned issues

Comment 2 Alexandre Emsenhuber [IAlex] 2009-01-10 13:46:30 UTC

Changed available version for MediaWiki 1.13 at http://www.mediawiki.org/wiki/Extension:Configure#Versions. That version should not break with MediaWiki 1.13.

Comment 3 Alon Swartz 2009-01-13 14:11:04 UTC

I installed the recommended revision from subversion (43933), and the exact same fatal error is produced. Why did I bother bugfixing and supplying a patch I don't know...

"""
Fatal error: Call to undefined method SkinMonoBook::link() in /var/lib/mediawiki/extensions/Configure/SpecialConfigure.php on line 36
"""

Comment 4 Alexandre Emsenhuber [IAlex] 2009-01-14 16:18:19 UTC

Updated version on extension's description page.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links