Last modified: 2010-05-15 15:33:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3684, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 1684 - [Patch] Fix Windows ImageMagick Thumbnails
[Patch] Fix Windows ImageMagick Thumbnails
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.4.x
PC Windows 2000
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-10 20:34 UTC by Chris Nelson
Modified: 2010-05-15 15:33 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris Nelson 2005-03-10 20:34:54 UTC
If the thumbnail or source image lives in a path containing a space (IE:
C:\Program Files), then when $wgUseImageMagick is set, the thumbnail will fail
to be created, under windows.

To get around this, you merely need to insert quotation marks around the
filenames. These lines are intended to replace lines 462-465 of includes/Image.php:

$cmd  =  $wgImageMagickConvertCommand .
					" -quality 85 -background white -geometry {$width} \"".
					($this->imagePath) . "\" \"" .
					($thumbPath) . "\"";
Comment 1 Brion Vibber 2005-03-10 22:24:57 UTC
This is incorrect and potentially dangerous. Use wfEscapeShellArg().
Comment 2 Rob Church 2006-06-01 01:15:34 UTC
Unable to reproduce the originally reported behaviour under SVN trunk; suspect
this was fixed since 1.6 and poss. 1.5 branches.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links