Last modified: 2010-05-15 15:33:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1684 - [Patch] Fix Windows ImageMagick Thumbnails
[Patch] Fix Windows ImageMagick Thumbnails
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
PC Windows 2000
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2005-03-10 20:34 UTC by Chris Nelson
Modified: 2010-05-15 15:33 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Chris Nelson 2005-03-10 20:34:54 UTC
If the thumbnail or source image lives in a path containing a space (IE:
C:\Program Files), then when $wgUseImageMagick is set, the thumbnail will fail
to be created, under windows.

To get around this, you merely need to insert quotation marks around the
filenames. These lines are intended to replace lines 462-465 of includes/Image.php:

$cmd  =  $wgImageMagickConvertCommand .
					" -quality 85 -background white -geometry {$width} \"".
					($this->imagePath) . "\" \"" .
					($thumbPath) . "\"";
Comment 1 Brion Vibber 2005-03-10 22:24:57 UTC
This is incorrect and potentially dangerous. Use wfEscapeShellArg().
Comment 2 Rob Church 2006-06-01 01:15:34 UTC
Unable to reproduce the originally reported behaviour under SVN trunk; suspect
this was fixed since 1.6 and poss. 1.5 branches.

Note You need to log in before you can comment on or make changes to this bug.