Last modified: 2014-10-17 03:41:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18821, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16821 - Make CentralNotice banner-hiding cookie work cross-site
Make CentralNotice banner-hiding cookie work cross-site
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Normal enhancement with 5 votes (vote)
: ---
Assigned To: Matt Walker
: fun-com, fundraising
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-28 19:54 UTC by Brion Vibber
Modified: 2014-10-17 03:41 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2008-12-28 19:54:45 UTC
Currently the collapse/expand state for the centralnotice banner is stored in a domain-specific browser cookie.

For those not using the secure.wikimedia.org interface (which puts all wikis on a single domain), this means they have to click the collapse thingy for every wiki they visit.

Further, if you visit the wikis from multiple computers or multiple browsers, the collapse state doesn't come with you. :(

For people who are logged in with a global account, it ought to be possible to stick the collapse/expand state into some kind of global preference that goes with the account; thus once logged in you'd stick with the option anywhere. This however would be dependent on having an infrastructure for maintaining such preferences, *and* some way to save it. :P

(bug 14950?)

I'm pretty sure we won't get to this in the next couple weeks, but this would be good to target to have done before the 2009-2010 fundraiser.

At a minimum, setting the cookie at one level up might be nice (eg *.wikipedia.org instead of just en.wikipedia.org).
Comment 1 Tomasz Finc 2009-03-12 23:17:49 UTC
Do we have any use for NOT collapsing it across all sites? If not then it should not be too hard to do.  
Comment 2 Mike.lifeguard 2009-03-12 23:30:09 UTC
(In reply to comment #1)
> Do we have any use for NOT collapsing it across all sites? If not then it
> should not be too hard to do.  
> 

Other than propagandizing/annoying users as much as possible, no. I'm not sure that's a goal we should have though :D
Comment 3 Brion Vibber 2009-03-16 19:22:13 UTC
Setting a domain-wide cookie is easy; doing it cross-domain is a bit harder (like how we do the login/logout cookies with images to hit the 3rd-party cookies).
Comment 4 Ryan Kaldari 2010-09-30 01:16:41 UTC
We should also include the GeoIPLookup info used by CentralNotice in the same cookie if possible.
Comment 5 Marcin Cieślak 2011-03-11 23:26:25 UTC
As a workaround (until bugs 27968 and 27448 are fixed), I am using Privoxy (http://www.privoxy.org) proxy filter and the rule:

{ +block{wikimedia}}
meta.wikimedia.org/w/index.php\?title=Special:Banner.*
geoiplookup.wikimedia.org

After the abovementioned bugs are fixed, the above will be fetched using SSL and not will not be within proxy's reach. 

Privoxy, has, however ability to independently send a cookie to a site on behalf of the browser, so something like

{ +add-header{Cookie: mediawikicentralnotice=0} }
.wikipedia.org
.wikimedia.org
.wikiquote.org
.wikisource.org
....
....

could solve half of the problem (accepting a cookie) but not setting it cross-wiki.
Comment 6 Marcin Cieślak 2011-03-12 02:59:17 UTC
Please also see bug 17108 which says the reverse - each notice should have its own cookie.
Comment 7 Ryan Kaldari 2011-03-12 05:19:25 UTC
Theoretically, we could do both. Each banner has its own cookie(s) that hide it globally once set. Of course that puts us about at the same place we are now as far as how much close box clicking each editor has to do.

Without any clear guidance from either the community or the WMF I'm reluctant to implement either of these, however.
Comment 8 Ryan Kaldari 2011-12-06 21:08:09 UTC
Right now the domain parameter isn't set for the banner-hiding cookie, so it
just defaults to the full hostname (e.g. 'en.wikipedia.org'). To fix this we
would need to have it set to the domain name only, preceded by a dot (e.g.
'.wikipedia.org'). See SpecialBannerController line 195.
Comment 9 Ryan Kaldari 2012-01-25 01:20:52 UTC
I'm retitling this bug to focus its scope on changing the cookie domain, as this is the most reasonable solution until bug 14950 is fixed.
Comment 10 Matt Walker 2013-07-30 01:36:29 UTC
Actually, on second reading this isn't blocked on 14950; I just need to modify Special:HideBanners.
Comment 11 Erik Moeller 2013-10-29 20:26:58 UTC
This is being discussed in:

http://lists.wikimedia.org/pipermail/wikitech-ambassadors/2013-October/thread.html#459

Does the approach https://wikimediafoundation.org/wiki/Template:HideBanners still work? If so it might be feasible to link to some variant of this page as a global-hide for non-fundraising banners until we have a better solution.
Comment 12 Gerrit Notification Bot 2013-10-30 21:32:08 UTC
Change 92777 had a related patch set uploaded by Mwalker:
Crosswiki Banner Hiding

https://gerrit.wikimedia.org/r/92777
Comment 13 Gerrit Notification Bot 2013-10-30 23:33:37 UTC
Change 92777 merged by jenkins-bot:
Crosswiki Banner Hiding

https://gerrit.wikimedia.org/r/92777
Comment 14 Gerrit Notification Bot 2013-10-31 00:03:17 UTC
Change 92817 had a related patch set uploaded by Mwalker:
Enable CentralNotice CrossWiki Hiding

https://gerrit.wikimedia.org/r/92817
Comment 15 Gerrit Notification Bot 2013-11-04 22:20:26 UTC
Change 92817 merged by Mwalker:
Enable CentralNotice CrossWiki Hiding

https://gerrit.wikimedia.org/r/92817
Comment 16 Matt Walker 2013-11-04 23:29:11 UTC
Seems to be working -- marking as resolved.
Comment 17 Gerrit Notification Bot 2014-04-15 19:44:37 UTC
Change 126065 had a related patch set uploaded by Mwalker:
Enable CentralNotice CrossWiki Hiding

https://gerrit.wikimedia.org/r/126065
Comment 18 Gerrit Notification Bot 2014-04-15 23:00:35 UTC
Change 126065 merged by Mwalker:
Enable CentralNotice CrossWiki Hiding

https://gerrit.wikimedia.org/r/126065
Comment 19 Nemo 2014-04-17 15:49:17 UTC
Ouch, killed the cluster https://gerrit.wikimedia.org/r/#/c/126998/
Comment 20 Matt Walker 2014-07-03 16:27:11 UTC
Heh; that's true; but then we re-enabled it here: https://gerrit.wikimedia.org/r/#/c/126998/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links