Last modified: 2009-05-01 01:13:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18805, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16805 - Certain Special: pages should not import JavaScript
Certain Special: pages should not import JavaScript
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Chad H.
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-26 21:59 UTC by MZMcBride
Modified: 2009-05-01 01:13 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2008-12-26 21:59:28 UTC
While the likelihood of abuse is low here, certain Gadgets or even site-wide JS on some projects is not watched closely (or it imports obscure subpages, etc.).

Pages like Special:UserRights, Special:UserLogin, Special:ChangePassword should not import JavaScript to avoid potential abuse.
Comment 1 Chad H. 2008-12-27 07:47:55 UTC
I'll take a look at this. Should be able to do something like we did with Special:UserLogin (cf bug 10005)
Comment 2 Splarka 2009-04-03 21:33:10 UTC
ChangePass and UserLogin make perfect sense to disable gadgets on. UserRights does not. Lemme splain:

If you have compromised someone's javascript, you can simply send an ajax request to Special:UserRights, scrape the form, get the token, and submit it it back. Same for most other Special pages.

You can't do this for ChangePass, because it requires them to enter their password. Same for UserLogin.

Site JS should be trusted enough to load on all pages (except maybe UserLogin).

Suggest WONTFIX for UserRights (some people automate the process, especially on Meta) and Site JS suggestions, and dupe to bug 18186 for the Gadgets (both CSS and JS, CSS can execute javascript in some browsers!) disabling on ChangePass/etc.
Comment 3 Chad H. 2009-05-01 01:13:43 UTC
No reason to disable for user rights, per comment #2.

Closing as FIXED: Userlogin, Resetpass, Preferences all have user JS disabled.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links