Last modified: 2009-01-02 00:24:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18754, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16754 - Making arbitrary rows of sortable tables sticky
Making arbitrary rows of sortable tables sticky
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-22 10:01 UTC by René Kijewski
Modified: 2009-01-02 00:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch against r44879 (1.24 KB, patch)
2008-12-22 10:01 UTC, René Kijewski
Details

Description René Kijewski 2008-12-22 10:01:47 UTC
Created attachment 5609 [details]
Patch against r44879

Sometimes it would be useful when specific rows of a sortable table would not change their position while reordering. E.g. repeated captions should be sticky.

I propose to overload the class unsortable for rows.
Comment 1 Filip Maljkovic [Dungodung] 2008-12-24 20:21:58 UTC
This is similar to bug 16347.
Comment 2 René Kijewski 2008-12-24 22:19:33 UTC
(In reply to comment #1)
> This is similar to bug 16347.
 
Why did you mark it as invalid?
Comment 3 Filip Maljkovic [Dungodung] 2008-12-24 23:09:03 UTC
I didn't. The original bug-reporter did. I don't know why, though.
Comment 4 Raimond Spekking 2008-12-26 22:01:40 UTC
Patch applied with r45060.
Comment 5 Derk-Jan Hartman 2009-01-02 00:03:20 UTC
It seems that this patch is creating some trouble with tablesorting for users in some cases.

Please see reports here:
http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Sortable_tables_.26_Firefox_3.0.5
Comment 6 René Kijewski 2009-01-02 00:21:32 UTC
I see: Only users with bad coded scripts are affected.

The line
> for(var i in staticRows) {
needs to be changed to
> for(var i = 0; i < staticRows.length; ++i) {
Comment 7 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-01-02 00:24:03 UTC
(In reply to comment #6)
> I see: Only users with bad coded scripts are affected.
> 
> The line
> > for(var i in staticRows) {
> needs to be changed to
> > for(var i = 0; i < staticRows.length; ++i) {

Already did it in r45304.  Reclosing unless it can be demonstrated that a) this commit caused the problem, b) it's not already fixed.  (And in that case, might be better to file a bug depending on this one.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links