Last modified: 2011-11-20 18:58:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1672 - html upload fails even when extension .html is whitelisted
html upload fails even when extension .html is whitelisted
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.17.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-09 22:14 UTC by Chris Nelson
Modified: 2011-11-20 18:58 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Adds a new global, $wgDisableUploadScriptChecks, which will disable the checks (2.10 KB, patch)
2009-06-17 02:06 UTC, Emufarmers
Details

Description Chris Nelson 2005-03-09 22:14:06 UTC
The UploadForm::Verify() method will still fail really basic html files, even
when the extension is whitelisted, removed from the blacklist, and file
extensions aren't checked nor strict. The only way to upload html files was to
comment out the $this->verify() section of SpecialUpload.php (lines 210-212).
I'm deploying this mediawiki on my corporate intranet, so all users are trusted.
There should be some way to express this trust in the user settings, without
commenting out useful code like verify().
Comment 1 Ævar Arnfjörð Bjarmason 2005-06-14 15:51:17 UTC
I've done this recently in HEAD and REL1_4, please confirm whether or not the
problem persists.

Marking this as WORKSFORME.
Comment 2 Emufarmers 2009-06-17 02:02:15 UTC
There's still no way to disable UploadForm::detectScript() without commenting out code.
Comment 3 Emufarmers 2009-06-17 02:06:18 UTC
Created attachment 6233 [details]
Adds a new global, $wgDisableUploadScriptChecks, which will disable the checks
Comment 4 Chad H. 2009-09-22 19:47:07 UTC
(In reply to comment #3)
> Created an attachment (id=6233) [details]
> Adds a new global, $wgDisableUploadScriptChecks, which will disable the checks
> 

Cf bug 18684.
Comment 5 p858snake 2011-04-30 00:09:41 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 6 Roan Kattouw 2011-11-20 18:58:47 UTC
Modified patch committed in r103772.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links