Last modified: 2010-05-15 16:03:06 UTC
The patch was cut using diff -ur and you should have added a -N to pick up the added file. Applying the patch to an existing installation breaks Image Uploads. This is the line in the patch file. Only in mediawiki-1.13.3/includes: IEContentAnalyzer.php This is the error message in our httpd/error_log [Mon Dec 15 19:38:37 2008] [error] [client 216.186.145.118] PHP Fatal error: AutoLoader::require() [<a href='function.require'>function.require</a>]: Failed opening required '/home/johne/public_html/wiki/includes/IEContentAnalyzer.php' (include_path='/home/johne/public_html/wiki:/home/johne/public_html/wiki/includes:/home/johne/public_html/wiki/languages:.:/usr/share/pear:/usr/share/php') in /home/johne/public_html/wiki/includes/AutoLoader.php on line 508, referer: http://www.elviscostello.info/wiki/index.php/Special:Upload You need to at least replace the patch file. I really feel your pain. I am the RTEMS maintainer and I always worry about making a mistake cutting a release.
I'm just glad I left the checksums out of the email this time around. Patches (and signatures) updated.
Maybe you are doing more than I think but if you only update the patch, doesn't that mean that anyone who installed the patch during the 12 or so hours while it did not include this file will have broken uploads? Anyone impacted will not be likely to reread the release notes or reinstall the patch. How about putting this file beside the new patch on the site and make an announcement that the original patch was missing this file and if you don't have it in your include directory, grab it from the ftp site and install it.
*** Bug 17013 has been marked as a duplicate of this bug. ***
