Last modified: 2008-12-16 01:15:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18643, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16643 - Some diffs are escaped thus appear in single line
Some diffs are escaped thus appear in single line
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-14 11:24 UTC by Danny B.
Modified: 2008-12-16 01:15 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Danny B. 2008-12-14 11:24:46 UTC
Some diffs are escaped thus appear in single line

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/42010

I was unable to find the dependencies though :-/ - some diffs are OK, some are like this one.
Comment 1 Aaron Schulz 2008-12-14 20:18:38 UTC
Don't have this locally, maybe it has to do with the proxy svn fetcher
Comment 2 Brion Vibber 2008-12-16 01:15:25 UTC
A null byte crept into the file in that diff, which seems to confuse the crap out of the particular json_decode implementation we happen to have live.

json_decode has the lovely behavior that sometimes, without easily being able to predict why, sometimes it returns your literal string, or... a slightly decoded literal string... instead of actually decoding it, if it's invalid, or sometimes if it seems to be valid but it doesn't like it, or wtf?

Anyway, I switched the proxy from using JSON to PHP serialization, and it just passes the string through correctly now. Whee!

r44643, r44644.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links