Last modified: 2009-01-23 22:07:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18641, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16641 - Errors in centralnotice.js
Errors in centralnotice.js
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Tomasz Finc
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-14 08:43 UTC by Christian Thiele
Modified: 2009-01-23 22:07 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Thiele 2008-12-14 08:43:12 UTC
There are CSS and HTML errors in the currect centralnotice.js, which breaks every single wikipedia page at the moment!

The first thing is, that there is no attribute "onClick" in XHTML, it should be "onclick", which occurs several times in the centralnotice.js

The second thing only affects the german version: http://upload.wikimedia.org/centralnotice/wikipedia/de/centralnotice.js
There you can find the line "{\n color: #006699;\n text-decoration: none;\n}" but without any class/id before it, so this is incorrect css, which triggers errors on the console...
Comment 1 Tomasz Finc 2008-12-15 01:40:12 UTC
It would be really helpful if you could reference which of the templates you saw this with. I'll sift through them and see where were inconsistent.
Comment 2 Brion Vibber 2008-12-15 01:45:53 UTC
Looking at the JS output.... the CSS issue is in 2008_is_a_nonprofit_meter.

The onClick thing I see several times, so check all the recently edited templates... (Note this one doesn't actually hurt anything, though it's technically wrong for XHTML. Should be "onclick" all lowercase.)
Comment 3 Tomasz Finc 2008-12-15 01:53:56 UTC
I walked through all the in use templates and changed case on any that were not lower case. Do let know if that pops up again.

Checking on the classless definition now...
Comment 4 Tomasz Finc 2008-12-15 02:22:21 UTC
That rogue color seems to have crept from a missing

.notice-wrapper a,
.notice-collapsed-wrapper a

I added those wherever they were missing (mostly in the meter templates) and we should be set now. 

Do let know if you still see those errors and thanks for pointing them out.
Comment 5 Christian Thiele 2008-12-15 10:09:14 UTC
Thank you. All errors seem to be fixed.
Comment 6 Christian Thiele 2009-01-23 17:48:08 UTC
The problem reoccured.
See: http://upload.wikimedia.org/centralnotice/wikipedia/de/centralnotice.js?195xx or http://upload.wikimedia.org/centralnotice/wikipedia/en/centralnotice.js?195xx

There you'll find:

.notice-wrapper-election a,
{
    color: #006699;
}

the comma there is wrong, so "color" will be interpreted like a selector, which will produce errors. 
Comment 7 Tomasz Finc 2009-01-23 22:07:29 UTC
Good catch! I went ahead and removed the comma. For any new issues with notices feel free to cut a separate bugzilla
ticket so that we can know how often this is hapinging uniquely. 

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links