Last modified: 2008-12-20 02:14:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 16639 - Code Review buttons can be considered "confusing"
Code Review buttons can be considered "confusing"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Aaron Schulz
http://www.mediawiki.org/wiki/Special...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-14 01:30 UTC by p858snake
Modified: 2008-12-20 02:14 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description p858snake 2008-12-14 01:30:31 UTC
When going to post a comment in a code review page the buttons (Commit Changes, Commit & Next unresolved, Preview) maybe confusing to the end user and have them thinking they are doing something to the code compared to just posting a comment about it.
Comment 1 Chad H. 2008-12-14 05:07:19 UTC
What would you suggest? "Save changes?" I'm all for improving it, just can't think of good wording.
Comment 2 p858snake 2008-12-14 05:16:21 UTC
Maybe something like "Post Comment", "Preview Comment"?
Comment 3 Brion Vibber 2008-12-15 19:47:10 UTC
Well it ain't just comments, it's also updating tags and status on the revision (if you have perms for that).
Comment 4 Chad H. 2008-12-15 19:51:28 UTC
(In reply to comment #3)
> Well it ain't just comments, it's also updating tags and status on the revision
> (if you have perms for that).
> 

Which is why I couldn't think of anything better. "Save post" is misleading, considering you can do a lot more :)
Comment 5 Simon Walker 2008-12-15 20:47:32 UTC
How about "Save changes", "Save changes & next unresolved" and "Preview" (just as an alternative suggestion)?
Comment 6 Alex B 2008-12-19 15:32:03 UTC
You could just add a note somewhere saying that this action won't effect the code. 'Save changes' also might be better, as people are more likely to associate 'commit' with a code update.
Comment 7 Aaron Schulz 2008-12-20 02:14:50 UTC
(In reply to comment #6)
> You could just add a note somewhere saying that this action won't effect the
> code. 'Save changes' also might be better, as people are more likely to
> associate 'commit' with a code update.
> 

Done in r44828

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links