Last modified: 2011-07-22 00:11:27 UTC
After my change on the template the template site is sometimes not shown. In the most cases a blank page is returned with an 500er. Sometimes an error message with PHP fatal error in /usr/local/apache/common-local/php-1.5/extensions/FlaggedRevs/FlaggedArticle.php line 1479: <br/> Object of class Revision could not be converted to string is returned. If you purge the page everything works fine for YOU (only!) for some time. Other users also see this bug some hours later, and have to purge once again. The template itself works fine when included into other sites and all links are set correctly. Another user reported that this bug it not shown if not logged in. Discussion was done in irc and on http://de.wikipedia.org/w/index.php?title=Wikipedia:Administratoren/Anfragen&oldid=53885766#Archiv-Vorlage_sch.C3.BCtzen (in german).
As it seems, this is not a bug in FlaggedRevs, but in CoreParserFunctions.php : pagesize() contains the lines > $revid = Revision::newFromTitle($title); > $parser->mOutput->addTemplate($title, $id, $revid); Instead of the actual revid it stuffs the whole Revision object into the parser output. Curiously this hasn't led to problems before.
Created attachment 5566 [details] propsed fix, adds a call to $rev->getId()
Fixed in r44433
