Last modified: 2011-04-14 15:14:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18579, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16579 - Problem with User.php if no cookies present
Problem with User.php if no cookies present
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.13.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-12-07 02:53 UTC by Wolfgang Fahl
Modified: 2011-04-14 15:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Wolfgang Fahl 2008-12-07 02:53:45 UTC 
When trying to login into a wiki immediately after clearing all cookies in a browser the
access to the $_SESSION variable in line 2111 will fail, since it is not set.
Here is the fix:

		if (isset($_SESSION)) 
			$_SESSION = $session + $_SESSION;
		else
		  $_SESSION = $session;
Comment 1 Aaron Schulz 2009-01-03 16:40:35 UTC 
Done in r45374
Comment 2 Brion Vibber 2009-01-07 04:28:59 UTC 
r45374 doesn't look like it'll have any affect whatsoever -- !is_null() and isset() will be returning the same result, so there'll be no change in behavior. If it was wrong before, it's still wrong.
Comment 3 Aaron Schulz 2009-01-07 13:32:49 UTC 
is_null throws notices if the variable is not defined.
Comment 4 Brion Vibber 2009-01-07 20:20:36 UTC 
So the state of the bug was "already fixed" before r45374, and r45374 was simply a cleanup for a notice warning in the already-existing fix?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links