Last modified: 2014-09-24 01:04:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18530, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16530 - Edit summaries containing multiple autocomments are broken
Edit summaries containing multiple autocomments are broken
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.18.x
All All
: Low minor with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikipedia.org/w/index.php?t...
:
: 15481 18253 43356 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-12-02 16:29 UTC by P.Copp
Modified: 2014-09-24 01:04 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Proposed fix for regex in Linker->formatAutocomments (532 bytes, patch)
2008-12-02 16:29 UTC, P.Copp 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description P.Copp 2008-12-02 16:29:04 UTC 
Created attachment 5552 [details]
Proposed fix for regex in Linker->formatAutocomments

If an edit summary contains more than one autocomment (/* ... */), only the last one is transformed into a section link.

This behavior was introduced by r39594 , though I'm not sure if it was intended this way. In case it wasn't, I attached a quick fix for the regex in Linker->formatAutocomments. A proper solution would probably take a bit more effort. :)
Comment 1 Siebrand Mazeland 2009-01-06 23:17:23 UTC 
+need-review
Comment 2 P.Copp 2009-03-30 10:58:20 UTC 
*** Bug 18253 has been marked as a duplicate of this bug. ***
Comment 3 Alexandre Emsenhuber [IAlex] 2009-08-02 14:50:43 UTC 
*** Bug 15481 has been marked as a duplicate of this bug. ***
Comment 4 Jeff G. 2010-09-15 01:34:04 UTC 
It is still not working.  I have a test case at http://en.wikipedia.org/w/index.php?title=Help:Edit_summary&diff=384901084&oldid=384900839
Comment 5 Sumana Harihareswara 2011-09-30 14:27:30 UTC 
I can verify that this is still happening with MediaWiki 1.18, as shown in this test:

https://secure.wikimedia.org/wikipedia/test2/w/index.php?title=Ecology&action=historysubmit&diff=35177&oldid=7899

Paul, could you check to see whether your patch still applies cleanly against trunk, and revise/modify if necessary?  Thanks!
Comment 6 Sumana Harihareswara 2011-11-24 19:28:40 UTC 
I'm sorry for the wait, Paul.  Because of the delay in reviewing your contribution, MediaWiki's codebase has changed enough that the patch no longer applies cleanly to trunk.  If you revise and update the patch, and mark it with the "patch" and "need-review" keywords, we'll ensure someone reviews it a lot faster.  My regrets, again.  Thank you.
Comment 7 Sumana Harihareswara 2011-11-24 19:29:06 UTC 
Comment on attachment 5552 [details]
Proposed fix for regex in Linker->formatAutocomments

Per automated testing
http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html patch
no longer applies to MediaWiki trunk in Subversion.
Comment 8 db [inactive,noenotif] 2013-01-02 11:59:44 UTC 
*** Bug 43356 has been marked as a duplicate of this bug. ***
Comment 9 Gerrit Notification Bot 2014-09-09 15:46:03 UTC 
Change 159326 had a related patch set uploaded by Anomie:
Format multiple autocomments in edit summaries

https://gerrit.wikimedia.org/r/159326
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links