Last modified: 2008-12-03 00:00:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18529, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16529 - fix IE bug in mwsuggest.js os_eventKeydown where keycode is undefined
fix IE bug in mwsuggest.js os_eventKeydown where keycode is undefined
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal major with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-02 13:07 UTC by Mck
Modified: 2008-12-03 00:00 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mck 2008-12-02 13:07:39 UTC
when other javascripts are included in a webpage that use event handlers, eg prototype.js,
os_eventKeydown does not work (for example the arrow keys) because the keycode is undefined.

Replacing the line in os_eventKeydown

        os_cur_keypressed = (window.Event) ? e.which : e.keyCode;

with

        if (undefined != e.keyCode)       
            os_cur_keypressed = e.keyCode;
        else                              
            os_cur_keypressed = e.which;  


You can see this modification in action at http://sesam.no/katalog/
Comment 1 Brion Vibber 2008-12-03 00:00:56 UTC
Applied in r44162.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links