Last modified: 2008-11-29 22:18:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18498, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16498 - Fatal Error while editing from old revision
Fatal Error while editing from old revision
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.14.x
All All
: Normal major (vote)
: ---
Assigned To: Aaron Schulz
http://meta.yourwiki.net/w/index.php?...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-11-29 22:11 UTC by Charles Melbye
Modified: 2008-11-29 22:18 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Charles Melbye 2008-11-29 22:11:13 UTC 
Users have reported getting Fatal Errors while editing an old revision of a page (an example has been set as the URL of this bug):

Fatal error: Call to protected method Article::setOldSubtitle() from context 'EditPage' in /home/yourwiki/htdocs/html/w/includes/EditPage.php on line 1182

This should be a simple fix, but I don't want to break anything, so what are your thoughts on it?
Comment 1 Charles Melbye 2008-11-29 22:11:32 UTC 
Changed severity to major, woops.
Comment 2 Platonides 2008-11-29 22:17:12 UTC 
Broken on r44015.
Just remove the protected word on line 2855 of Article.php until it is fixed.

As http://www.mediawiki.org/wiki/Coding_Conventions says
"Newer code will use proper visibilities, but do not add it to existing code without first checking, testing and refactoring as required, because the above rule has been broken in several places"
Comment 3 Alexandre Emsenhuber [IAlex] 2008-11-29 22:18:40 UTC 
fixed in r44051.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links