Last modified: 2008-12-27 20:36:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18484, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16484 - User rights log adds extra comma when unneeded
User rights log adds extra comma when unneeded
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.14.x
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
: testme
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-28 14:46 UTC by Danielle Lawson
Modified: 2008-12-27 20:36 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
special case for two messages in log (1.51 KB, patch)
2008-12-03 21:33 UTC, Nakon
Details

Description Danielle Lawson 2008-11-28 14:46:17 UTC
I used the latest SVN build and noticed this oddity in the user rights log entry:
14:22, 28 November 2008 WikiSysop (Talk | contribs) changed group membership for User:TestUser from Sysops to Sysops, and Bureaucrats ‎ (temporary)

Is there meant to be a comma when adding another usergroup?? It used to be:
14:22, 27 November 2008 WikiSysop (Talk | contribs) changed group membership for User:Testing from Sysops to Sysops and Bureaucrats ‎ (test)

Anyone know why this has happened on the trunk version?? It doesn't seem to appear on any Wikimedia sites.
Comment 1 Nakon 2008-12-03 21:33:21 UTC
Created attachment 5554 [details]
special case for two messages in log

Removed the comma from MediaWiki:and and moved the adding of a comma into Language.php
Comment 2 Raimond Spekking 2008-12-27 20:00:40 UTC
Modified patch applied with r45101: "... moved the adding of a comma into Language.php" was unneeded.
Comment 3 charitwo 2008-12-27 20:05:19 UTC
To be honest, the behavior of the logs now is silly. It made much more sense to have for example:

14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership
for User:Testing from sysop to sysop, bureaucrat ‎(test)

instead of

14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership
for User:Testing from Sysops to Sysops and Bureaucrats ‎(test)
Comment 4 Mike.lifeguard 2008-12-27 20:17:38 UTC
(In reply to comment #3)
> To be honest, the behavior of the logs now is silly. It made much more sense to
> have for example:
> 
> 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership
> for User:Testing from sysop to sysop, bureaucrat ‎(test)
> 
> instead of
> 
> 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership
> for User:Testing from Sysops to Sysops and Bureaucrats ‎(test)
> 

I don't see why. Lists of this sort in English are separated by a comma, with 'and' between the last two items (comma there optional depending on who you ask). "Sysops and Bureaucrats" is more correct and "Sysops, Bureaucrats" isn't (though the caps and plural is wrong wrong wrong) - perhaps that's not true in other languages.
Comment 5 charitwo 2008-12-27 20:36:42 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > To be honest, the behavior of the logs now is silly. It made much more sense to
> > have for example:
> > 
> > 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership
> > for User:Testing from sysop to sysop, bureaucrat ‎(test)
> > 
> > instead of
> > 
> > 14:22, 28 December 2008 WikiSysop (Talk | contribs) changed group membership
> > for User:Testing from Sysops to Sysops and Bureaucrats ‎(test)
> > 
> 
> I don't see why. Lists of this sort in English are separated by a comma, with
> 'and' between the last two items (comma there optional depending on who you
> ask). "Sysops and Bureaucrats" is more correct and "Sysops, Bureaucrats" isn't
> (though the caps and plural is wrong wrong wrong) - perhaps that's not true in
> other languages.
> 

At the very least, the plurality and capitalization can be removed. Though this isn't really considered a list, it's a log entry. And I still stand by my opposition for the current format with the usage of "and".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links