Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18436, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 16436 - Don't add block log entry if no settings actually change

Summary:	Don't add block log entry if no settings actually change

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: User blocking (Other open bugs) Version: 1.14.x Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: http://commons.wikimedia.org/wiki/Spe... Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2008-11-23 04:37 UTC by Mike.lifeguard Modified: 2009-02-21 10:19 UTC (History) CC List: 3 users (show) aschulz4587 niklas.laxstrom str4nd See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments /mediawiki/phase3/includes/Block.php (493 bytes, patch) 2009-02-20 13:53 UTC, str4nd Details Add an attachment (proposed patch, testcase, etc.)

Description Mike.lifeguard 2008-11-23 04:37:28 UTC If the block settings don't actually change, don't add a new entry to the block log. Instead, perhaps return a message saying "You've not changed anything, try again" Comment 1 Aaron Schulz 2008-11-23 09:53:22 UTC Done in r43870 Comment 2 str4nd 2009-02-20 13:53:37 UTC Created attachment 5835 [details] /mediawiki/phase3/includes/Block.php It didn't reblock if only the reason has changed. Comment 3 Niklas Laxström 2009-02-21 10:19:37 UTC r47604